Skip to content

Commit

Permalink
Remove flake8 from Python builds as linting is added to commits in #6937
Browse files Browse the repository at this point in the history
  • Loading branch information
geographika committed Oct 4, 2023
1 parent 10ee9f5 commit 5485dad
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 13 deletions.
9 changes: 0 additions & 9 deletions src/mapscript/python/CMakeLists.txt
Expand Up @@ -73,15 +73,6 @@ add_custom_command(

add_custom_command(
DEPENDS mapscriptvenv.stamp
OUTPUT mapscriptlinting.stamp
WORKING_DIRECTORY ${OUTPUT_FOLDER}
COMMAND ${Python_VENV_SCRIPTS}/flake8 $<TARGET_FILE_DIR:${SWIG_MODULE_pythonmapscript_REAL_NAME}>/mapscript/tests --max-line-length=140
COMMAND ${Python_VENV_SCRIPTS}/flake8 $<TARGET_FILE_DIR:${SWIG_MODULE_pythonmapscript_REAL_NAME}>/mapscript/examples --max-line-length=120
COMMENT "Linting test suite and examples with flake8" # note only one comment is output per custom command block
)

add_custom_command(
DEPENDS mapscriptlinting.stamp
OUTPUT mapscriptwheel.stamp
WORKING_DIRECTORY ${OUTPUT_FOLDER}
COMMAND ${Python_VENV_SCRIPTS}/python setup.py bdist_wheel > wheel_build.log
Expand Down
6 changes: 2 additions & 4 deletions src/mapscript/python/requirements-dev.txt
@@ -1,6 +1,4 @@
pytest
pillow
wheel>=0.31.1
setuptools>=40.2.0
flake8==3.9.2; python_version == '2.7'
flake8==5.0.3; python_version >= '3.0'
wheel>=0.38.0
setuptools>=45.0.0

0 comments on commit 5485dad

Please sign in to comment.