Skip to content

Commit

Permalink
[Lint] FLTProcessPropertyIsNull(): remove always true comparison (due…
Browse files Browse the repository at this point in the history
… to previous check)
  • Loading branch information
rouault committed Oct 31, 2023
1 parent 23c4f71 commit f5060a3
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/mapogcfilter.cpp
Expand Up @@ -3150,9 +3150,8 @@ int FLTProcessPropertyIsNull(FilterEncodingNode *psFilterNode, mapObj *map,
layerWasOpened = msLayerIsOpen(lp);

/* Horrible HACK to compensate for the lack of null testing in MapServer */
if ((lp->connectiontype == MS_POSTGIS ||
(lp->connectiontype == MS_OGR && msOGRSupportsIsNull(lp))) &&
strcmp(psFilterNode->pszValue, "PropertyIsNull") == 0) {
if (lp->connectiontype == MS_POSTGIS ||
(lp->connectiontype == MS_OGR && msOGRSupportsIsNull(lp))) {
msFree(psFilterNode->pszValue);
psFilterNode->pszValue = msStrdup("PropertyIsEqualTo");
psFilterNode->psRightNode = FLTCreateBinaryCompFilterEncodingNode();
Expand Down

0 comments on commit f5060a3

Please sign in to comment.