Swig MapScript for Multi-Label Support

[sdlime]

Need to add methods for manipulating multiple label objects in the context of classObj's. Need to implement the RFC 24 reference counting as well (necessary attributes have been added to appropriate structures). styleObj support should serve as a pattern.

Steve

[sdlime]

I added three new methods for a classObj in SWIG MapScript: getLabel, addLabel, removeLabel. They mirror the style support except that order is not important for labels so addLabel doesn't take an index and just adds the new label to the end. These are in the master.

Tamas, in class.i there were some C-Sharp specific directives around insertStyle that I wasn't sure if they applied here or not. Can you comment?

Steve

[szekerest]

This change is required to update the object relationship for the c# garbage collector. Modified the code accordingly.

[tbonfort]

@aboudreault , have the corresponding functions been added to php mapscript ?

[aboudreault]

not yet. another thing to add to my todo list.

[aboudreault]

In my commit:

• Fix memory leak in msAddLabelToClass()
• Add addLabel/removeLabel/getLabel in classObj of PHP MapScript
• Add numlabels property in classObj in PHP Mapsciprt
• Add labelObj capability to be instantiated. (was always embedded before) (PHP and SWIG)

I think we can close this ticket?

[sdlime]

I can try to add to PHP. It was my contract responsibility...

On Wed, May 23, 2012 at 10:11 AM, Thomas Bonfort
reply@reply.github.com
wrote:

@aboudreault , have the corresponding functions been added to php mapscript ?

---

Reply to this email directly or view it on GitHub:
#4310 (comment)

[aboudreault]

it's done steve. Documentation is missing though...

[sdlime]

Thanks man. Let's leave open untils docs get the update. Steve

[havatv]

I have updated mapscript documentation (mapscript/mapscript.txt and mapscript/php/index.txt) - MapServer/MapServer-documentation@ae0a68a.

Properties for class: numlabels added, label marked as removed.

Methods for class: addLabel, getLabel, removeLabel.

I have also updated two figures to indicate that multiple labels can be used for class.

If the update is OK, I hope that @aboudreault or @sdlime can close this bug. I can't.

[aboudreault]

Thanks havatv!

[szekerest]

labelObj.expression a labelObj.text is not exposed to mapscript. Also missing from the mapfile/mapscript documentation

[havatv]

@tbonfort, should something be done also for PHP mapscript? I could not find settext and setexpression in the 6.2 PHP code.

[jmckenna]

Reopening. LabelObj text and expression params are not exposed yet in PHP MapScript.

[tbonfort]

not sure if this can be ready for 6.2.1 . @aboudreault ?

[aboudreault]

will do tomorrow morning

[aboudreault]

Fixed in branch-6-2 and master.