Tracking issue for RFC 91 #4974

sdlime · 2014-08-19T15:02:37Z

This is a tracking issue for merging RFC 91 branches into master.

http://mapserver.org/fr/development/rfc/ms-rfc-91.html

msmitherdc · 2014-08-19T15:52:01Z

@sdlime looks like node->tokenval.tmval.tm_min is not being populated.

String: (`[TIME]` = `2004-01-01 17:10:00`) OR (`[TIME]` = `2004-01-01 14:10:00`)
msOracleSpatialLayerTranslateFilter. There are tokens to process
Minute value is 0

@msmitherdc -- checking on it... --Steve

msmitherdc · 2014-08-19T17:38:14Z

@sdlime also, the quoting of all identifiers for oracle is creating some backwards incompatibility issues. When quoted, oracle uses the case of identifiers, so users will have up upcase their identifiers. I think we should only quote when the escape ("") character is present.

sdlime · 2014-08-21T15:12:42Z

@msmitherdc, I take it you are referring to the msLayerEscapePropertyName() function. I don't think we should monkey with the default version defined in maplayer.c. You should instead create an Oracle specific version that does what you need and register that in the Oracle driver vtable. --Steve

msmitherdc · 2014-08-22T19:08:28Z

@sdlime ok, got the identifier issue worked out.

msmitherdc · 2014-09-07T11:58:27Z

@sdlime looks like the CLUSTER keyword doesn't work for me in 7/rfc91. I get these items being treated as columns. This happens with Oracle backend, OGR, and shapefiles.

Error:[Sun Sep 7 07:56:29 2014].44203 msDBFGetItemIndex(): DBASE file error. Item 'Cluster:FeatureCount' not found.

Example layer definition:

LAYER
  NAME eq_cluster
  TYPE POINT
  STATUS off
  EXTENT -179.987600 -61.325200 179.976100 74.552100
  #CONNECTIONTYPE OGR
  #CONNECTION "earthquakes.db"
  #DATA "grid.earthquakes"
  DATA "earthquakes.shp"
  CLASSITEM "Cluster:FeatureCount"
  LABELITEM "Cluster:FeatureCount"
  PROJECTION
    "init=epsg:4326"
  END
  CLUSTER
    MAXDISTANCE 50
    REGION "ellipse"
  END
  CLASS
    NAME "Earthquakes-cluster"
    EXPRESSION ("[Cluster:FeatureCount]" != "1")
    STYLE
      SYMBOL "circle"
      SIZE 50
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
    CLASS
    NAME "Earthquakes-single"
    EXPRESSION "1"
    STYLE
      SYMBOL "circle"
      SIZE 18
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
  END
  UNITS PIXELS
  TOLERANCE 10
END # layer

sdlime · 2014-09-07T18:14:54Z

Expressions should be unaffected by RFC 91 although there were some modest changes to msWhichItems(). Can you post the full mapfile.

Steve

From: Michael D. Smith [notifications@github.com]
Sent: Sunday, September 07, 2014 6:58 AM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] Tracking issue for RFC 91 (#4974)

@sdlimehttps://github.com/sdlime looks like the CLUSTER keyword doesn't work for me in 7/rfc91. I get these items being treated as columns. This happens with Oracle backend, OGR, and shapefiles.

Error:[Sun Sep 7 07:56:29 2014].44203 msDBFGetItemIndex(): DBASE file error. Item 'Cluster:FeatureCount' not found.

Example layer definition:

LAYER
NAME eq_cluster
TYPE POINT
STATUS off
EXTENT -179.987600 -61.325200 179.976100 74.552100
#CONNECTIONTYPE OGR
#CONNECTION "earthquakes.db"
#DATA "grid.earthquakes"
DATA "earthquakes.shp"
CLASSITEM "Cluster:FeatureCount"
LABELITEM "Cluster:FeatureCount"
PROJECTION
"init=epsg:4326"
END
CLUSTER
MAXDISTANCE 50
REGION "ellipse"
END
CLASS
NAME "Earthquakes-cluster"
EXPRESSION ("[Cluster:FeatureCount]" != "1")
STYLE
SYMBOL "circle"
SIZE 50
COLOR 255 140 0
OUTLINECOLOR 0 0 0
END
CLASS
NAME "Earthquakes-single"
EXPRESSION "1"
STYLE
SYMBOL "circle"
SIZE 18
COLOR 255 140 0
OUTLINECOLOR 0 0 0
END
END
UNITS PIXELS
TOLERANCE 10
END # layer

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4974#issuecomment-54744677.

msmitherdc · 2014-09-07T20:17:42Z

Full mapfile

MAP
NAME "earthquakes-cluster"
STATUS ON
SIZE 1000 800
SYMBOLSET "../etc/symbols.txt"
EXTENT -180 -90 180 90
UNITS DD
SHAPEPATH "../data"
IMAGECOLOR 255 255 255
FONTSET "../etc/fonts.txt"

WEB
  IMAGEPATH "/ms4w/tmp/ms_tmp/" 
  IMAGEURL "/ms_tmp/"
END

PROJECTION
  "init=epsg:4326"
END

#
# Start of layer definitions
#

LAYER
  NAME 'global-raster'
  TYPE RASTER
  DATA "./GLOBALeb3colshade.jpg"
  STATUS DEFAULT
  CLASS
    NAME 'Earth Image' 
  END
  PROJECTION
    "init=epsg:4326"
  END  
END

LAYER
  NAME "earthquakes-cluster"
  TYPE POINT
  STATUS DEFAULT
  EXTENT -179.987600 -61.325200 179.976100 74.552100
  CONNECTIONTYPE OGR
  CONNECTION "earthquakes.db"
  DATA "grid.earthquakes"
  CLASSITEM "Cluster:FeatureCount"
  LABELITEM "Cluster:FeatureCount"
  PROJECTION
    "init=epsg:4326"
  END
  ###########################
  # Define the cluster object
  ###########################
  CLUSTER
    MAXDISTANCE 50
    REGION "ellipse"
  END  
  #Return all shapes when querying
  PROCESSING "CLUSTER_GET_ALL_SHAPES"
  CLASS
    NAME "Earthquakes-cluster"
    EXPRESSION ("[Cluster:FeatureCount]" != "1")
    #EXPRESSION ("[Cluster:FeatureCount]" > "50")
    STYLE
      SYMBOL "circle"
      SIZE 50
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
    LABEL
      FONT sans
      TYPE TRUETYPE
      SIZE 8
      COLOR 120 120 120
      ALIGN CENTER
      PRIORITY 10
      BUFFER 1
      PARTIALS TRUE
      POSITION cc
    END     
  END 
  CLASS
    NAME "Earthquakes-single"
    EXPRESSION "1"
    STYLE
      SYMBOL "circle"
      SIZE 18
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END    
  END  
  UNITS PIXELS
  TOLERANCE 10  
END # layer



END # Map File

msmitherdc · 2014-09-07T20:25:12Z

@sdlime link with data etc http://1drv.ms/1rqq1D7

msmitherdc · 2014-09-08T04:26:53Z

@sdlime ok, there is no issue with clusters, its a documentation issue. with (szekerest@794cdcc) the syntax was changed from using a colon (:) to an underscore (_). And thats not in the docs. I'll open a doc ticket about it.

sdlime · 2014-09-08T04:29:44Z

Whew...

From: Michael D. Smith [notifications@github.com]
Sent: Sunday, September 07, 2014 11:26 PM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] Tracking issue for RFC 91 (#4974)

@sdlimehttps://github.com/sdlime ok, there is no issue with clusters, its a documentation issue. with (szekerest@794cdcchttps://github.com/szekerest/mapserver/commit/794cdcc64620d2c1958bfede5ec1c5424c0592de) the syntax was changes from using a colon (:) to an underscore (_). And thats not in the docs. I'll open a doc ticket about it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4974#issuecomment-54775760.

…erver#4974,MapServer#4995)

…tangle (MapServer#4974) * Reprojection of BBOX to layer SRS should be done as a rectangle to avoid capturing too many features. Improves wfsogr10_twolayer.xml * Also add a hack from -180,-90,180,90 BBOX when reprojecting to a projected SRS.

…#4974) Should fix wfsogr10_twolayer.xml

…filter.png (MapServer#4974, MapServer#4999)

Make following tests to pass : wms_get_map_sld_proj.png, wms_get_map_multi_polygon_filter.png, wms_get_map_multi_polygon_filter_postgis.png

Fix post RFC91 issues in mapogcsld.c (#4974)

tbonfort · 2015-02-12T18:37:07Z

We can close this one now, yay!

sdlime added this to the 7.0 Release milestone Aug 19, 2014

msmitherdc mentioned this issue Aug 23, 2014

Allow OracleSpatial Connection to Specify an Spatial index #4890

Closed

tbonfort added a commit that referenced this issue Sep 13, 2014

Use bounding-box specific reprojection code (#4974)

2d312c5

tbonfort mentioned this issue Sep 17, 2014

Inconsistent WFS Filter results between OGR vs. shapelib #4995

Closed

sdlime mentioned this issue Sep 18, 2014

RFC91/postgis explicitely cast string bindings to text (#4974) #4996

Closed

tbonfort added a commit to MapServer/msautotest_DEPRECATED that referenced this issue Sep 18, 2014

use correctly capitalized column names (MapServer/MapServer#4974)

df6241a

tbonfort added a commit that referenced this issue Sep 18, 2014

RFC91/postgis explicitely cast string bindings to text (#4974)

648ec49

rouault pushed a commit to rouault/mapserver that referenced this issue Sep 20, 2014

don't evaluate filter expression before geometry has been setup (MapS…

fcda97a

…erver#4974,MapServer#4995)

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

msOGRFileWhichShapes(): fix taking into account of filters (MapServer…

6902603

…#4974) Should fix wfsogr10_twolayer.xml

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

Fix regression of previous commit in ogr_multi_defer.png and ogr_attr…

6a4d00e

…filter.png (MapServer#4974, MapServer#4999)

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

Fix post RFC91 issues in mapogcsld.c (MapServer#4974)

eeaf85b

Make following tests to pass : wms_get_map_sld_proj.png, wms_get_map_multi_polygon_filter.png, wms_get_map_multi_polygon_filter_postgis.png

sdlime mentioned this issue Sep 20, 2014

Fix post RFC91 issues in mapogcsld.c (#4974) #5000

Merged

sdlime added a commit that referenced this issue Feb 10, 2015

Merge pull request #5000 from rouault/fix_rfc91_sld

8120558

Fix post RFC91 issues in mapogcsld.c (#4974)

tbonfort closed this as completed Feb 12, 2015

szekerest added a commit that referenced this issue Jun 4, 2015

Implement msMSSQL2008LayerTranslateFilter (#4974)

ad0aa44

szekerest mentioned this issue Sep 9, 2016

OGC polygon filter not used with Sql Server #4603

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for RFC 91 #4974

Tracking issue for RFC 91 #4974

sdlime commented Aug 19, 2014

msmitherdc commented Aug 19, 2014

msmitherdc commented Aug 19, 2014

sdlime commented Aug 21, 2014

msmitherdc commented Aug 22, 2014

msmitherdc commented Sep 7, 2014

sdlime commented Sep 7, 2014

msmitherdc commented Sep 7, 2014

msmitherdc commented Sep 7, 2014

msmitherdc commented Sep 8, 2014

sdlime commented Sep 8, 2014

tbonfort commented Feb 12, 2015

Tracking issue for RFC 91 #4974

Tracking issue for RFC 91 #4974

Comments

sdlime commented Aug 19, 2014

msmitherdc commented Aug 19, 2014

msmitherdc commented Aug 19, 2014

sdlime commented Aug 21, 2014

msmitherdc commented Aug 22, 2014

msmitherdc commented Sep 7, 2014

sdlime commented Sep 7, 2014

msmitherdc commented Sep 7, 2014

msmitherdc commented Sep 7, 2014

msmitherdc commented Sep 8, 2014

sdlime commented Sep 8, 2014

tbonfort commented Feb 12, 2015