Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hidden random build dep on abseil-cpp ? #6822

Closed
landryb opened this issue Feb 6, 2023 · 2 comments
Closed

hidden random build dep on abseil-cpp ? #6822

landryb opened this issue Feb 6, 2023 · 2 comments

Comments

@landryb
Copy link
Contributor

landryb commented Feb 6, 2023

support for flatgeobuf added in #6520 adds an undefined build behaviour depending wether abseil-cpp is installed here:

MapServer/flatgeobuf/include/flatbuffers/base.h

Line 218 in 6da3b29

#ifndef FLATBUFFERS_HAS_STRING_VIEW

if built with C++11 (the default ?) and clang 13 (default compiler on OpenBSD) and a recent version of abseil-cpp happens to be installed, the build will fail because abseil-cpp insists on c++14.

absl/policy_checks.h:79:2: error: "C++ versions less than C++14 are not supported."

Cf https://marc.info/?t=167567663600006&r=1&w=2 for the reasoning..
rouault added a commit to rouault/flatbuffers that referenced this issue Feb 11, 2023
@rouault
Add a FLATBUFFERS_DO_NOT_USE_ABSL macro to not use absl even if found
cde8c4b 
If flatbuffers is built in C++11 mode, but there is a recent version of
absl which requires C++14, the build will fail.
This commit adds a FLATBUFFERS_DO_NOT_USE_ABSL that the user can set to
ask not to use absl headers.
Cf MapServer/MapServer#6822 for the use case
that triggered this.
@rouault rouault mentioned this issue Feb 11, 2023
Merged
@rouault
Copy link
Contributor

rouault commented Feb 11, 2023

Attempt at fixing that in FlatBuffers upstream: google/flatbuffers#7824

@landryb
Copy link
Contributor Author

landryb commented Feb 13, 2023

that's another possible fix, thanks @rouault

rouault added a commit to rouault/flatbuffers that referenced this issue Feb 15, 2023
@rouault
Only use absl headers if C++14 is available.
3d88680 
If flatbuffers is built in C++11 mode, but there is a recent version of
absl which requires C++14, the build will fail.
Cf MapServer/MapServer#6822 for the use case
that triggered this.
dbaileychess pushed a commit to google/flatbuffers that referenced this issue Feb 15, 2023
@rouault
Only use absl headers if C++14 is available. (#7824)
a56f9ec 
If flatbuffers is built in C++11 mode, but there is a recent version of
absl which requires C++14, the build will fail.
Cf MapServer/MapServer#6822 for the use case
that triggered this.
rouault added a commit that referenced this issue Feb 16, 2023
@rouault
Merge pull request #6833 from rouault/fix_6822
6360f80 
Fix build issue when abseil-cpp is present (fixes #6822)
github-actions bot pushed a commit that referenced this issue Feb 16, 2023
@rouault @github-actions
Fix build issue when abseil-cpp is present (fixes #6822)
0fc627e 
Port of upstream fix in google/flatbuffers#7824
jmckenna pushed a commit that referenced this issue Feb 16, 2023
@github-actions @rouault
Fix build issue when abseil-cpp is present (fixes #6822) (#6834)
747b5d0 
Port of upstream fix in google/flatbuffers#7824

Co-authored-by: Even Rouault <even.rouault@spatialys.com>
dbaileychess pushed a commit to google/flatbuffers that referenced this issue Mar 15, 2023
@rouault @dbaileychess
Only use absl headers if C++14 is available. (#7824)
a5655f4 
If flatbuffers is built in C++11 mode, but there is a recent version of
absl which requires C++14, the build will fail.
Cf MapServer/MapServer#6822 for the use case
that triggered this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rouault @landryb