Enable runtime substitutions using class level validation blocks
#4600
Conversation
This fixes /issues/4596. As well as now honouring class level validation blocks a validation hierarchy is implemented across `web`, `layer` and `class` level validation blocks. This hierarchy *only* takes effect when identical validation keys appear in `web`, `layer` or `class` such that keys in more specialised blocks override those in more generalised blocks. i.e. `class` overrides `layer` which overrides `web`. In conjunction with the above, default class level substitutions are also enabled and also implement the precedence rules above. i.e. a default substitution in `class` overrides `layer` which overrides `web`.
Previously the logic let through tags which didn't appear in the validation blocks.
|
@homme the CI server might not have mailed you, but your changes break 3 existing substitution testcases which should be checked given that adding CLASS substitutions is supposed to be backwards compatible. |
|
@tbonfort Thanks for the heads up. I've enabled I also note there are no tests for class validation: I can look at adding some if required. |
|
@mapserver-bot retest this please |
…apServer#4600) As well as now honouring class level validation blocks a validation hierarchy is implemented across `web`, `layer` and `class` level validation blocks. This hierarchy *only* takes effect when identical validation keys appear in `web`, `layer` or `class` such that keys in more specialised blocks override those in more generalised blocks. i.e. `class` overrides `layer` which overrides `web`. In conjunction with the above, default class level substitutions are also enabled and also implement the precedence rules above. i.e. a default substitution in `class` overrides `layer` which overrides `web`. Ensure validation *always* occurs when a substitution is requested Fixes MapServer#4596 Fixes MapServer#4600
ghost
assigned 
This fixes /issues/4596. As well as now honouring
class level validation blocks a validation hierarchy is implemented
across
web,layerandclasslevel validation blocks. Thishierarchy only takes effect when identical validation keys appear in
web,layerorclasssuch that keys in more specialised blocksoverride those in more generalised blocks. i.e.
classoverrideslayerwhich overridesweb.In conjunction with the above, default class level substitutions are
also enabled and also implement the precedence rules above. i.e. a
default substitution in
classoverrideslayerwhich overridesweb.