Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all instances of strdup to msStrdup #5313

Closed
wants to merge 3 commits into from

Conversation

geographika
Copy link
Member

@geographika geographika commented Aug 30, 2016

See issue #5277 - fixes Windows memory issues in conjunction with using msFree

I left the following in mapstring.c alone. I presume this shouldn't be called anyway if only msStrdup is used?

#ifndef HAVE_STRDUP
char  *strdup(char *s)
{
  char  *s1;
  ...

@tbonfort
Copy link
Member

  • There's still a call to strdup in mapcopy.h
  • The calls to strdup in mapscript should also probably be changed
  • As you noted, you can remove the mapserver provided strdup() function and the HAVE_STRDUP cmake check

@geographika
Copy link
Member Author

Superseded by #5321

@geographika geographika closed this Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants