Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another batch of Coverity scan fixes #6336

Merged
merged 61 commits into from May 23, 2021
Merged

Another batch of Coverity scan fixes #6336

merged 61 commits into from May 23, 2021

Conversation

rouault
Copy link
Contributor

@rouault rouault commented May 22, 2021

We should be close to the end, as normally all remaining warnings should be adressed... (I'd expect a few ones requiring other follow up fixes though)

rouault added 30 commits May 22, 2021 17:29
@rouault
mappostgis: fix Untrusted loop bound warning (CID 1503262)
a642754
@rouault
agg_scanline_storage_aa.h: initialize member variable (CID 1175307)
b60eb89
@rouault
agg_scanline_storage_bin.h: initialize member variable (CID 1175306)
51e7e3d
@rouault
agg_font_cache_manager.h: initialize member variables (CID 1175305)
4d76128
@rouault
agg_curves.h: curve3_div: initialize member variables (CID 1175304)
03afa53
@rouault
agg_curves.h: curve3_inc: initialize member variables (CID 1175303)
86de666
@rouault
agg_color_rgba.h: initialize member variables (CID 1175302)
210a7d5
@rouault
agg clipper.cpp: initialize member variables (CID 1175300)
2712647
@rouault
agg_conv_adaptor_vcgen.h: initialize member variable (CID 1175299)
ffa5eb7
@rouault
agg_scanline_p.h: initialize member variable (CID 1175298)
f95a9af
@rouault
agg_curves.h: curve4_div: initialize member variables (CID 1175295)
57c8342
@rouault
agg_curves.h: curve4_inc: initialize member variables (CID 1175294)
805e069
@rouault
agg_scanline_bin.h: initialize member variable (CID 1175297)
4532c0e
@rouault
agg_scanline_u.h: initialize member variable (CID 1175293)
f4eb1aa
@rouault
agg_rasterizer_scanline_aa.h: initialize member variable (CID 1175292)
1fd27ef
@rouault
agg_path_storage_integer.h: initialize member variables (CID 1175291)
db1dcdf
@rouault
agg_basics.h: initialize member variables (CID 1175290)
549d04c
@rouault
mapkmlrenderer.cpp: initialize member variables (CID 1175289)
08fce9f
@rouault
agg_rasterizer_outline_aa.h: initialize member variables (CID 1175288)
9339064
@rouault
agg_line_aa_basics.h: initialize member variables (CID 1175287)
40979f5
@rouault
agg_renderer_outline_image.h: initialize member variable (CID 1175286)
48b690a
@rouault
agg_dda_line.h: initialize member variables (CID 1175284)
cd93051
@rouault
agg_image_accessors.h: initialize member variables (CID 1175283)
559a5ab
@rouault
agg_vertex_sequence.h: initialize member variables (CID 1175281)
d933e60
@rouault
agg_vcgen_stroke.h: initialize member variable (CID 1175280)
8358604
@rouault
agg_vcgen_dash.h: initialize member variables (CID 1175279)
2c0ab6c
@rouault
agg_vcgen_contour.h: initialize member variable (CID 1175278)
64b9fb9
@rouault
agg_path_storage.h: avoid warning about nullptr deref (CID 1175262)
c680389
@rouault
agg_path_storage.h: avoid warning about nullptr deref (CID 1175261)
b7c90b5
@rouault
mapdraw.c: avoid warning about nullptr deref (CID 1174977)
92afd76
rouault added 27 commits May 22, 2021 18:37
@rouault
maptree.c: avoid untrusteed argument (CID 1174468)
4f4ee61
@rouault
mapshape.c: avoid untrusteed loop (CID 1174466)
fcf13d8
@rouault
mapquery.c: fix Untrusted loop bound (CID 1174463)
db16f3e
@rouault
mapquery.c: fix Untrusted loop bound (CID 1174462)
13c0f85
@rouault
shp2img.c: fix Untrusted loop bound (CID 1174460)
04d17b6
@rouault
mapwfs11.cpp: fix (too large) memory allocation (CID 1174453)
4ec0f76
@rouault
mapquantization.c: fix Unintended sign extension (CID 1174447, 117444…
a3105dc 
…8, 1174449, 1174450)
@rouault
maptemplate.c: remove useless nullptr check (CID 1174444)
a70e199
@rouault
maptemplate.c: remove useless nullptr check (CID 1174443)
a1d4b4d
@rouault
maptemplate.c: fix Argument cannot be negative (CID 1174362)
a4dd977
@rouault
shptreetst.c: fix Dereference after null check (CID 1174355)
7c3147c
@rouault
maplayer.c: fix Dereference after null check (CID 1174345)
2e4fe66
@rouault
mapuvraster.c: avoid division by zero (CID 1174340)
9bb93e4
@rouault
maptree.c: check fseek() return value (CID 1174326)
496bb0d
@rouault
mapcluster.c: check ret value of msInitializeVirtualTable() (CID 1174…
3d1c52d 
…316)
@rouault
maptemplate.c: ignore ret val of msReturnTemplateQuery() (CID 1174298)
9886ef5
@rouault
clipper.cpp: remove dead code (CID 1132971)
4cd9da8
@rouault
clipper.hpp: initialize member variables (CID 1041052)
a703dbb
@rouault
clipper.cpp: silence copy_paste_error warning (CID 1041005)
24c4c28
@rouault
clipper.cpp: avoid warning about nullptr deref (CID 1041002)
4563b01
@rouault
clipper.cpp: avoid warning about nullptr deref (CID 1041001)
77db171
@rouault
mapcrypto.c: silence warning about risky function (CID 1503553)
0e3e729
@rouault
agg_font_freetype.cpp: avoid assigned value that is never used (CID 1…
f28623a 
…503490)
@rouault
mapwfs11.cpp: don't assign variable that is never read (CID 1503405)
60fd420
@rouault
mapagg.cpp: avoid assigned value that is never used (CID 1503381)
a319bab
@rouault
mapogcsos.c: don't assign variable that is never read (CID 1503348)
4e09bdc
@rouault
mapwfs20.c: fix wrong sizeof() (without consequence) (CID 1194601, 11…
c7e2188 
…74455)
@jmckenna jmckenna added this to the 8.0 Release milestone May 23, 2021
@jmckenna
Copy link
Member

thanks @rouault !

@jmckenna jmckenna merged commit 0d156a7 into MapServer:main May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rouault @jmckenna