Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeFilter: Allow time filter to append to an existing layer filter #6408

Merged

Conversation

ashleysommer
Copy link
Contributor

TimeFilter: Allow time filter to append to an existing filter if the filter is an expression
WCS: Don't remove existing TileIndexLayer filter when applying time filter.
Fixes #6406
Fixes #6407

…filter is an expression

WCS: Don't remove existing TileIndexLayer filter when applying time filter.
Fixes MapServer#6406
Fixes MapServer#6407
@jmckenna
Copy link
Member

@ashleysommer is it possible for you to add a test for this in msautotest, as part of this pull request? (https://mapserver.org/development/tests/autotest.html) See example WCS tests in /msautotest/wxs

@ashleysommer
Copy link
Contributor Author

Yep, I thought that might be a requirement, so I'm looking into the examples to see how I would integrate a test for this.

@jmckenna
Copy link
Member

jmckenna commented Oct 7, 2021

@ashleysommer polite nudge for the test, as this would be nice to include in the 8.0 release. thanks!

@ashleysommer
Copy link
Contributor Author

Thanks for the reminder! I've been using this feature in production, built from my branch, I forgot it hasn't made its way into the upstream codebase yet.

maplayer.c Outdated Show resolved Hide resolved
maplayer.c Outdated Show resolved Hide resolved
maplayer.c Show resolved Hide resolved
maplayer.c Outdated Show resolved Hide resolved
maplayer.c Outdated Show resolved Hide resolved
maplayer.c Show resolved Hide resolved
maplayer.c Outdated Show resolved Hide resolved
maplayer.c Outdated Show resolved Hide resolved
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
maplayer.c Show resolved Hide resolved
@ashleysommer
Copy link
Contributor Author

Note, I'm still working on tests for this. I hope to have the tests merged by end of the day today.

@jmckenna
Copy link
Member

thanks @ashleysommer

Add a tiny sample timeseries of rasters with a tileindex to test against
@ashleysommer
Copy link
Contributor Author

Ok, test added. Hopefully it passes!

@rouault rouault merged commit 67b1f04 into MapServer:main Oct 21, 2021
@jmckenna
Copy link
Member

thanks @ashleysommer !

@pelord
Copy link

pelord commented Feb 29, 2024

Does this merged PR allow to combine Time filter and OGC filters?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants