-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimeFilter: Allow time filter to append to an existing layer filter #6408
TimeFilter: Allow time filter to append to an existing layer filter #6408
Conversation
…filter is an expression WCS: Don't remove existing TileIndexLayer filter when applying time filter. Fixes MapServer#6406 Fixes MapServer#6407
@ashleysommer is it possible for you to add a test for this in msautotest, as part of this pull request? (https://mapserver.org/development/tests/autotest.html) See example WCS tests in |
Yep, I thought that might be a requirement, so I'm looking into the examples to see how I would integrate a test for this. |
@ashleysommer polite nudge for the test, as this would be nice to include in the 8.0 release. thanks! |
Thanks for the reminder! I've been using this feature in production, built from my branch, I forgot it hasn't made its way into the upstream codebase yet. |
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Note, I'm still working on tests for this. I hope to have the tests merged by end of the day today. |
thanks @ashleysommer |
Add a tiny sample timeseries of rasters with a tileindex to test against
Ok, test added. Hopefully it passes! |
thanks @ashleysommer ! |
Does this merged PR allow to combine Time filter and OGC filters? |
TimeFilter: Allow time filter to append to an existing filter if the filter is an expression
WCS: Don't remove existing TileIndexLayer filter when applying time filter.
Fixes #6406
Fixes #6407