Allow Expressions to be set for LABEL properties using MapScript #6904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
reviewed
Jun 14, 2023
Make char a constant Co-authored-by: Even Rouault <even.rouault@spatialys.com>
Make char a constant Co-authored-by: Even Rouault <even.rouault@spatialys.com>
|
@rouault - thanks for the review - changes applied. E.g. MapServer/mapscript/swiginc/label.i Line 127 in 257c646 MapServer/mapscript/swiginc/label.i Line 116 in 257c646 MapServer/mapscript/swiginc/label.i Line 142 in 257c646 |
yes |
jmckenna
pushed a commit
to jmckenna/MapServer
that referenced
this pull request
Aug 3, 2023
…Server#6904) This pull request allows the new functionality in MapServer#6884 of using an expression in a LABEL PRIORITY in MapScript. It takes a similar approach to setting attribute bindings for properties, which requires using the appropriate attribute constant such as `MS_LABEL_BINDING_PRIORITY`: ```python label = mapscript.labelObj() label .setExpressionBinding(mapscript.MS_LABEL_BINDING_PRIORITY, "[MY_ATTRIBUTE] * 2") ``` This is a little clunky but is at least consistent with setting attribute bindings: ```python label = mapscript.labelObj() label.setBinding(mapscript.MS_LABEL_BINDING_COLOR, "NEW_BINDING") ``` While testing this I noticed that the `writeLabel` function used to write Mapfile objects ignored expressions. This seems an oversight also for the `LABEL` `SIZE` expression. If this approach seems appropriate I can use this for other expression bindings. Something to note is that a property could have an attribute binding **and** an expression binding set. In this case the attribute binding currently takes precedence when calculating a shape value, so it also takes precedence when writing to a Mapfile. In theory setting an expression could also set the attribute binding to NULL. This is not currently the case for MapScript or when reading a Mapfile twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the new functionality in #6884 of using an expression in a LABEL PRIORITY in MapScript.
It takes a similar approach to setting attribute bindings for properties, which requires using the appropriate attribute constant such as
MS_LABEL_BINDING_PRIORITY:This is a little clunky but is at least consistent with setting attribute bindings:
While testing this I noticed that the
writeLabelfunction used to write Mapfile objects ignored expressions. This seems an oversight also for theLABELSIZEexpression. If this approach seems appropriate I can use this for other expression bindings.Something to note is that a property could have an attribute binding and an expression binding set. In this case the attribute binding currently takes precedence when calculating a shape value, so it also takes precedence when writing to a Mapfile.
In theory setting an expression could also set the attribute binding to NULL. This is not currently the case for MapScript or when reading a Mapfile twice.