Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar on UPLOAD step of importer modal is gone #948

Closed
jonpmarino opened this issue Aug 14, 2017 · 5 comments
Closed

Progress Bar on UPLOAD step of importer modal is gone #948

jonpmarino opened this issue Aug 14, 2017 · 5 comments
Assignees

Comments

@jonpmarino
Copy link
Member

There used to be a progress bar during the Upload step of the Importer Modal. On BETA its no longer there. The user is still prevented from hitting the Next Step button until the Upload is complete however. Without a progress bar, it seems to a user like the Next Step button is just not working, and the user has no way of knowing that their Upload is actually in progress.

screen shot 2017-08-14 at 12 01 17 pm

@emilyashley
Copy link
Member

Where were we getting the layer.state from anyhow?

The template doesn't appear to be modified, but the "UPLOADED" layer state doesn't seem to be in scope, and the uploadInProgress has a #todo next to it.

@davisc
Copy link
Contributor

davisc commented Sep 14, 2017

@jonpmarino fixed in https://github.com/GeoNode/django-osgeo-importer/blob/master/osgeo_importer/static/osgeo_importer/importer.js

@cuttlefish may need to bump importer to this commit.

This snippet previously existed in the mapstory branch of importer as indicated by the version deployed to mapstory.org

screen shot 2017-09-13 at 8 13 54 pm

@emilyashley
Copy link
Member

confirmed this was bumped in cce50b9

@emilyashley
Copy link
Member

confirmed locally: Screen Shot 2017-09-18 at 3.38.31 PM.png

@jonpmarino jonpmarino removed this from the Launch Beta milestone Jun 11, 2018
@jonpmarino
Copy link
Member Author

jonpmarino commented Jun 11, 2018

Reopening for the backlog. the "Great, We've got your data!" info is different from the progress bar that used to exist and was the purpose of this issue. The progress bar showed a a percentage advancing as your dataset uploaded to let you know how much time was left. For example, in the screenshot I've uploaded a layer with 81,000 features. Right now there is no indicator to give me a sense of how long this upload will take. As a user, you're not sure if something is happening and, if so, how far along things are. So, as a user I click "next step" and nothing happens so I assume something is broken when actually the upload is still in process.
screen shot 2018-06-11 at 4 42 14 pm

If the percentage feature can't be re-implemented, at least just adding the spinning wheel that we already have for the "import" phase once the layer is "uploaded" would help. That at least tells the user a process is active. Here's a screenshot of the spinning wheel in action:
screen shot 2018-06-11 at 4 47 35 pm

@jonpmarino jonpmarino reopened this Jun 11, 2018
@Coop56 Coop56 self-assigned this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants