Refactor Mapstories + Storyframes + Storypins Apps #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternal naming. Migration added to change model names in database, tests passing.
…model instead of removing it.
…the ones in the apps directory.
…factor-mapstories-app
cuttlefish
reviewed
Jan 24, 2018
|
Yes the migrations should do what we need. It'll rename the database tables without deleting the data. I tested it locally, but I would agree testing it on staging (after staging has some stories with layers, pins and frames) makes sense. |
cuttlefish
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the naming used in the mapstories, storyframes and storypins apps. They were previously called boxes and annotations which did not line up with what we called these features. This must be merged at the same time as this MapLoom PR. MapStory/MapLoom#42