Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .NET 6.0 as Target Framework for Mapster.Tool #390

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

alifeofkaizen
Copy link
Contributor

Resolves #381

@alifeofkaizen alifeofkaizen changed the title Include .NET 6.0 as Target Framework - #387 Include .NET 6.0 as Target Framework Nov 16, 2021
@alifeofkaizen alifeofkaizen changed the title Include .NET 6.0 as Target Framework Include .NET 6.0 as Target Framework for Mapster.Tool Nov 16, 2021
@alifeofkaizen alifeofkaizen marked this pull request as ready for review November 16, 2021 09:57
Copy link

@mo3in mo3in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge it please.

and if possible we can use .net source generator for the future

@patrikmolsson
Copy link

What is preventing the merge of this PR?

We would really appreciate getting this in, since it's blocking our migration to .NET 6.

@chaowlert , @SergerGood

@andrerav
Copy link
Contributor

Just chiming in to show my support for merging this ASAP as well as following up with an updated Nuget package. @chaowlert @eswann @SergerGood

@frasermclean
Copy link

Any reason this 1 line PR is taking so long to merge?

@SergerGood
Copy link
Contributor

@frasermclean I have no right to do this

@andrerav
Copy link
Contributor

@chaowlert Have you had a time to look at this?

@prezek
Copy link

prezek commented Jan 18, 2022

Please, could someone merge this change?

@alifeofkaizen
Copy link
Contributor Author

Not sure if @chaowlert is still around? looks like he's been away for the last 6 months?
Might need to fork this project and issue a nuget release?

As a workaround for anyone else, simply pull this branch, bump the version #, compile, publish locally a nupkg and add locally...

@eswann eswann merged commit fbd65f1 into MapsterMapper:master Jan 29, 2022
@eswann
Copy link
Collaborator

eswann commented Feb 1, 2022

Hey @Kaizen365 , @patrikmolsson, @andrerav, @frasermclean, @SergerGood, @mo3in, I merged the PR, but it's been years since I've contributed to this project, and I haven't worked in the .Net space in a few years as well. I'm not sure what build procedures @chaowlert has been using to publish these packages out to Nuget and frankly I don't have the bandwidth currently to figure it out.
It looks like @chaowlert has gone dark for several months now, so I only hope that his health is OK. I would be happy to try to set up somebody else to do the necessary work if anyone would like to volunteer.

@byme8
Copy link

byme8 commented Feb 7, 2022

@eswann Looks like I managed to build and generate the Nuget packages for Mapster. It was pretty straightforward.

git clone git@github.com:MapsterMapper/Mapster.git
cd ./Mapster/src
// change the nuget version number in the ./src/Mapster.Tool/Mapster.Tool.csproj from 8.2.0 to 8.2.1
dotnet build -c Release
dotnet pack -c Release -o ./out

After that, there will be a bunch of the Nuget packages in the ~/src/out/ folder. As I understood, you need the Mapster.Tool.8.2.1.nupkg. It can be uploaded directly to nuget.org.

@eswann
Copy link
Collaborator

eswann commented Feb 7, 2022

@byme8 Yeah that would be the manual way, but I know I would have automated it to some extent back when I worked on this thing. I see a deploy directory using psake (not sure if that's still used).

@SergerGood
Copy link
Contributor

Hey, @eswann. I could do this, but I need permissions to work with the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ef core 6.x support
9 participants