Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions to old unsupported frameworks from projects #579

Merged
merged 1 commit into from
May 29, 2023

Conversation

satano
Copy link
Member

@satano satano commented Apr 15, 2023

  • Cleanup of conditions in project files to other (old) frameworks, which are not used anymore. All projects in solution targets just .NET 6.
  • I also changed element <TargetFrameworks> to <TargetFramework> everywhere.

@satano
Copy link
Member Author

satano commented Apr 15, 2023

I made this PR because there really is no need for these conditions when those frameworks are not supported. But I am curious, Mapster is dropping support for (old) .NET Framework? I do not mean .NET Core 3.x (or less), but full .NET Framework 4.x.

@andrerav andrerav merged commit b8eba45 into MapsterMapper:master May 29, 2023
1 check passed
@andrerav
Copy link
Contributor

Thanks! Yes, it's not sustainable to maintain support for .NET Framework unfortunately (this has to do with how the code generation works). Users that require this library on that platform can use the older versions of Mapster.

@satano satano deleted the removeOldFrameworks branch July 18, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants