Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapsui.Wpf is incompatible with System.Drawing.Common 8.0.0 #2324

Closed
edgarssults opened this issue Dec 8, 2023 · 3 comments · Fixed by #2325
Closed

Mapsui.Wpf is incompatible with System.Drawing.Common 8.0.0 #2324

edgarssults opened this issue Dec 8, 2023 · 3 comments · Fixed by #2325
Labels
enhancement
Milestone
4.1

Comments

@edgarssults
Copy link

Mapsui Version
4.1.1

Mapsui Platform
WPF

Device
Windows 11

Describe the bug
If System.Drawing.Common is updated to 8.0.0 there is a warning in the build log about an incompatibility.
warning NU1608: Detected package version outside of dependency constraint: Mapsui.Wpf 4.1.1 requires System.Drawing.Common (>= 7.0.0 && < 8.0.0) but version System.Drawing.Common 8.0.0 was resolved.

To Reproduce
Steps to reproduce the behavior:

  1. Reference MapsUi.Wpf 4.1.1 in project
  2. Reference System.Drawing.Common 8.0.0
  3. Build and check log

Expected behavior
There is no warning, MapsUi.Wpf supports System.Drawing.Common 8.0.0.

Additional context
Observed while migrating a solution to .NET 8.
@edgarssults edgarssults changed the title MapsUi.Wpf incompatible with System.Drawing.Common 8.0.0 MapsUi.Wpf is incompatible with System.Drawing.Common 8.0.0 Dec 8, 2023
@pauldendulk
Copy link
Member

Perhaps we should just remove the upper bound in our nuget package. There will be no breaking changes in WPF going to 8

@pauldendulk pauldendulk mentioned this issue Dec 8, 2023
Merged
@pauldendulk pauldendulk linked a pull request Dec 8, 2023 that will close this issue
Remove upper bound on some System.* nugets #2325
Merged
@pauldendulk
Copy link
Member

The upper bound of System.Drawing.Common will be removed in 4.1.1-preview.2 but there might be other limitations.
#2325

@pauldendulk pauldendulk added this to the 4.1 milestone Dec 11, 2023
@pauldendulk pauldendulk changed the title MapsUi.Wpf is incompatible with System.Drawing.Common 8.0.0 Mapsui.Wpf is incompatible with System.Drawing.Common 8.0.0 Dec 11, 2023
@pauldendulk
Copy link
Member

Done with #2324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Remove upper bound on some System.* nugets Mapsui/Mapsui
2 participants
@pauldendulk @edgarssults