Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound on some System.* nugets #2325

Merged

Conversation

pauldendulk
Copy link
Member

This is an attempt to remedy this: #2324. But there are likely to be other limiting packages.

I only looked at the four System.* packages, because it is pretty save there are no breaking changes there.

  • System.Drawing.Common - Removed upper bound
  • System.Text.Encoding.CodePages - Removed upper bound
  • System.Linq.Async - Remove entirely because was not used
  • System.Memory - leave, it is a very specific workaround for some issue on iOS. Can be removed in master.

I don't have a general strategy wrt upper bounds yet. Two things to take into account:

  • If we test with one version we don't want to allow just any other version
  • If it is unlikely to introduce breaking changes we should allow higher major version.

Let's see where the next problem is.

@pauldendulk pauldendulk added this to the 4.1 milestone Dec 8, 2023
@pauldendulk pauldendulk linked an issue Dec 8, 2023 that may be closed by this pull request
@pauldendulk pauldendulk changed the title Feature/remove upper bound from the System nugets Remove upper bound from the System.* nugets Dec 8, 2023
@pauldendulk pauldendulk changed the title Remove upper bound from the System.* nugets Remove upper bound on some System.* nugets Dec 8, 2023
@pauldendulk pauldendulk merged commit 529b763 into develop/4.1 Dec 8, 2023
5 of 6 checks passed
@pauldendulk pauldendulk deleted the feature/remove-upper-bound-from-system-nugets branch December 8, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapsui.Wpf is incompatible with System.Drawing.Common 8.0.0
1 participant