v1.4.2 is broken #289
Comments
|
It is, check this commit 074a0f8 |
|
See #285 |
|
@dhilt please revert back to using |
|
@lirantal Thanks, will do! |
This reverts commit ee81a24.
|
@Marak Can you please kill 1.4.1 and 1.4.2 from npm and adjust latest back to 1.4.0 please ... It is breaking a lot! |
See Marak/colors.js#289. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
See Marak/colors.js#289. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
That's.... the point of why he has done that |
|
Marak should NOT be trusted as a developer! Especially after doing this unilaterally without notification. |
|
Please consider closing this issue so that people will go to #285 instead -- trying to keep solutions and updates in one place. Thanks. |
There is absolutely NO REASON to fuck over people this way! That's how you burn bridges and have people not trust you as an developer. |
|
I'm not saying what he has done was right but in my opinion he doesn't have
to notify someone with a change in his software, you're free to fork it and
all
…On Mon, Jan 10, 2022, 00:19 Dustin Williams ***@***.***> wrote:
@Marak <https://github.com/Marak> Can you please kill 1.4.1 and 1.4.2
from npm and adjust latest back to 1.4.0 please ... It is breaking a lot!
That's.... the point of why he has done that
There is absolutely NO REASON to fuck over people this way! That's how you
burn bridges and have people not trust you as an developer.
—
Reply to this email directly, view it on GitHub
<#289 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANZJY2P2KJ4R3CEUPCAAID3UVIJXBANCNFSM5LSITCWQ>
.
You are receiving this because you commented.Message ID: <Marak/colors.
***@***.***>
|
|
Sure, and that is EXACTLY what is happening. Marak is being cut out and deleted as nobody trusts him now. |
|
In my eyes there are two sides right now: I'm interested rigt now in Point 1 ... |
|
"ideally supporting him" Yeah, no. That would be deeply irresponsible. Not after this. Rewarding this sort of malicious behavior just leads to more of it. |
|
Did it so |
|
npx marak-free |
|
v1.4.1 is also broken |
|
Hi, in case the author will not maintain this project or fix this, I made a fork that restores the normal behaviour. I am not sure if I will maintain this package, but just in case the problem will not be solved and you don't want to be scared when running https://github.com/euberdeveloper/colors.js In any case I could also suggest passing to the chalk package, which is very good and has a serious and reliable author |
This reverts commit ee81a24.
|
Here is an alternative, optionally, you could easily write your own module :
|
|
@npm revert it to a working version. |
|
@TechStudent11 looks like @npm have indeed reverted https://www.npmjs.com/package/colors to 1.4.0 |
good |
|
Great, closing this as npm has removed broken versions and reverted to 1.4.0 |
It was released 1 hour ago and broke my tests in the following nice (not) way:
I fixed it in my lib by reverting package-lock.json: dhilt/ngx-ui-scroll@dd782fc (BTW it is suggested to downgrade to 1.4.0, thanks to @lirantal, so here's another downgrade commit)
I suppose it might relate to destruction of the Faker.js project (5 days ago): https://github.com/Marak/faker.js
The text was updated successfully, but these errors were encountered: