New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: liberty liberty zalgo bug #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing infinite loop
github has disabled marak's account |
So now that his account is suspended, who can merge this fix? |
Just switch to chalk, It's roughly the same API and step away from this shit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go
I have another question, why people use the package not |
I think because latest chalk versions throws an error when using it with Typescript about "Can't use ES6 module in commonjs" and only older versions work with Typescript but colors.js It's no problem. |
will this fix be merged soon? |
ah the power of github. You change your package however you want and they disable you. |
Doubt this PR will move forward... but you should also remove |
It's a cool art though so I prefer keeping it 😅 Let's just hope this PR gets merged for now and then think about the cool american art. |
Finally! |
kleur much better compared to chalk |
In terms of trustworthiness I trust Chalk wayyyyyyyy more than Kleur or Colors |
@@ -11,13 +11,3 @@ module['exports'] = colors; | |||
// | |||
// | |||
require('./extendStringPrototype')(); | |||
|
|||
/* remove this line after testing */ | |||
let am = require('../lib/custom/american'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should remove this file as well
@Marak you have claimed your account. Please merge this. |
Please use chalk or kleur or fork the repo and maintain it yourself. This won't go forward, this is intentional and there's not a single reason for leaving this PR open cause it's pretty much stale for the rest of life. |
Fixing the intentional liberty zalgo bug by a PR made on a freaking phone.
Fixing: #285 #289 #290