Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: liberty liberty zalgo bug #291

Closed
wants to merge 1 commit into from
Closed

Fix: liberty liberty zalgo bug #291

wants to merge 1 commit into from

Conversation

YassinEldeeb
Copy link

@YassinEldeeb YassinEldeeb commented Jan 10, 2022

Fixing the intentional liberty zalgo bug by a PR made on a freaking phone.

Fixing: #285 #289 #290

Copy link
Author

@YassinEldeeb YassinEldeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing infinite loop

@leohku leohku mentioned this pull request Jan 10, 2022
@postbird
Copy link

github has disabled marak's account

@postbird
Copy link

image

@elbojoloco
Copy link

So now that his account is suspended, who can merge this fix?

@YassinEldeeb
Copy link
Author

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

Copy link

@gbvanrenswoude gbvanrenswoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go

@postbird
Copy link

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

I have another question, why people use the package not chalk?

@YassinEldeeb
Copy link
Author

YassinEldeeb commented Jan 10, 2022

I have another question, why people use the package not chalk?

I think because latest chalk versions throws an error when using it with Typescript about "Can't use ES6 module in commonjs" and only older versions work with Typescript but colors.js It's no problem.

@lnzzz
Copy link

lnzzz commented Jan 10, 2022

will this fix be merged soon?

@YassinEldeeb
Copy link
Author

will this fix be merged soon?

@lnzzz probably no cause this is @Marak revenge for lack of open-source funding, use chalk instead or fork this repo and publish your own working version to npm.

@G2G2G2G
Copy link

G2G2G2G commented Jan 10, 2022

ah the power of github. You change your package however you want and they disable you.

@luislobo
Copy link

Doubt this PR will move forward... but you should also remove ../lib/custom/american

@YassinEldeeb
Copy link
Author

YassinEldeeb commented Jan 10, 2022

Doubt this PR will move forward... but you should also remove ../lib/custom/american

It's a cool art though so I prefer keeping it 😅

Let's just hope this PR gets merged for now and then think about the cool american art.

@Awilum
Copy link

Awilum commented Jan 10, 2022

Finally!

@Awilum
Copy link

Awilum commented Jan 10, 2022

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

kleur much better compared to chalk
https://www.npmjs.com/package/kleur

@BitesizedLion
Copy link

So now that his account is suspended, who can merge this fix?

Just switch to chalk, It's roughly the same API and step away from this shit.

kleur much better compared to chalk https://www.npmjs.com/package/kleur

In terms of trustworthiness I trust Chalk wayyyyyyyy more than Kleur or Colors

@@ -11,13 +11,3 @@ module['exports'] = colors;
//
//
require('./extendStringPrototype')();

/* remove this line after testing */
let am = require('../lib/custom/american');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should remove this file as well

@hello-smile6
Copy link

will this fix be merged soon?

@lnzzz probably no cause this is @Marak revenge for lack of open-source funding, use chalk instead or fork this repo and publish your own working version to npm.

Someone, JUST GIVE THEM FUNDING!

@TechStudent10
Copy link

@Marak you have claimed your account. Please merge this.

@YassinEldeeb
Copy link
Author

Please use chalk or kleur or fork the repo and maintain it yourself.

This won't go forward, this is intentional and there's not a single reason for leaving this PR open cause it's pretty much stale for the rest of life.

@YassinEldeeb YassinEldeeb deleted the patch-1 branch January 23, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet