Add stop() #10
Closed
Add stop() #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ideas on when this is going to be merged? Best Pietro |
|
|
||
|
|
||
|
|
||
| child = spawn(say.speaker, commands); |
There was a problem hiding this comment.
Assigning value to an undeclared variable is an error
|
Unfortunately this cannot be simply merged as the files are completely different. Also the approach of simply killing the child process doesn't work on Linux with Festival (though OS X with say might work). I'm trying to find a fix for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the need to stop say commands while they are playing, so I added
stop().