Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZyX, document autoget.py briefly #75

Closed
MarcWeber opened this issue Oct 28, 2013 · 5 comments
Closed

ZyX, document autoget.py briefly #75

MarcWeber opened this issue Oct 28, 2013 · 5 comments

Comments

@MarcWeber
Copy link
Owner

Can you add a high level overview what that code exactly does? The description can be very short but should contain the source of the repositories.

I imagine something like this:

# autoget.py: queries github and tries to associate github urls with vim script 
numbers by matching script names using some regular expression magic

Looks like one association is wrong:
#73

Do you have time to have a quick look at which is likely to be the right fix?

@ZyX-I
Copy link
Collaborator

ZyX-I commented Oct 29, 2013

# autoget.py: queries github and tries to associate github urls with vim script 
numbers by matching script names using some regular expression magic

Nothing near this. It downloads archive from www.vim.org and determines a list of file names. Then it checks whether list of file names obtained from the archive is contained in the one in the repository. If it is not, it performs the same check, but for *.vim, *.py, *.pm, *.lua and some other files only. Repository name only alters order of checking repository URLs in case there is more then one found.

@ZyX-I ZyX-I closed this as completed in 2bbb702 Oct 29, 2013
@MarcWeber
Copy link
Owner Author

In the repository ? Which repository URLS are matched against sources from vim.sf.net?

@ZyX-I
Copy link
Collaborator

ZyX-I commented Oct 29, 2013

In the repository ? Which repository URLS are matched against sources from vim.sf.net?

I do not understand. URLs are not matched against sources.

@MarcWeber
Copy link
Owner Author

After reading your nice documentation there are no more question. Adding the initial comment lines would have been enough. Now have a look at the original issue: #73. The description contains both: the github repository and a "mirror". Is it better to ask to drop the mirror line or to ignore vim-scripts urls in your code?

@ZyX-I
Copy link
Collaborator

ZyX-I commented Oct 29, 2013

Originally my script behaved correctly: it used URL where development goes (though I would expect it to use vim-scripts repo instead: name-based sorting worked, but it worked in reverse putting less likely candidates first). Maybe this is why there are exactly no vim-scripts matches in scm_generated.json.

Now sorting is fixed, but candidate with name match is ignored due to it being in vim-scripts repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants