Removed separate multicity_input Animations. #1
Conversation
|
Hey man! Thanks for PR! It looks much better! |
|
I think it's okay considering we're not rerunning the animation or even rebuilding the layout using setState(). My first instinct when I read your question was, if we run setState() at any point during or after the animation, it might restart. But when I did it myself using Future.delayed(), it didn't rerun either time. So I think it's fine compared to a state object. |
lib/multicity_input.dart
Outdated
| arrivalAnimation = new CurvedAnimation( | ||
| parent: textInputAnimationController, | ||
| curve: Interval(0.75, 0.95, curve: Curves.linear)); | ||
| textInputAnimationController.forward(); |
There was a problem hiding this comment.
It's not supposed to run on init. Only on plus click. Could you remove this line and then I will merge, ok? :)
There was a problem hiding this comment.
I guess I just forgot to remove that line after testing, I'll do it as soon as I can!
There was a problem hiding this comment.
I've removed line 20 starting the animation. Sorry for the delay.
|
Thank you for the contribution! |
Removed separate multicity_input Animations.