feat(config): allow configuration from package/workspace metadata

crates/release_plz/Cargo.toml

@@ -53,6 +53,5 @@ assert_cmd.workspace = true
 async-trait.workspace = true
 fake.workspace = true
 expect-test.workspace = true
-serde_json.workspace = true
 tempfile.workspace = true
 toml_edit.workspace = true

crates/release_plz/src/args/mod.rs

@@ -7,6 +7,7 @@ mod update;
 use std::path::{Path, PathBuf};
 
 use anyhow::Context;
+use cargo_metadata::Metadata;
 use release_plz_core::CARGO_TOML;
 use tracing::info;
 
@@ -59,7 +60,11 @@ fn local_manifest(project_manifest: Option<&Path>) -> PathBuf {
     }
 }
 
-fn parse_config(config_path: Option<&Path>) -> anyhow::Result<Config> {
+fn parse_config(
+    config_path: Option<&Path>,
+    project_manifest: Option<&Path>,
+    cargo_metadata: &Metadata,
+) -> anyhow::Result<Config> {
     let (config, path) = if let Some(config_path) = config_path {
         match std::fs::read_to_string(config_path) {
             Ok(config) => (config, config_path),
@@ -71,22 +76,66 @@ fn parse_config(config_path: Option<&Path>) -> anyhow::Result<Config> {
             },
         }
     } else {
-        match first_file_contents([
+        let file_contents = first_file_contents([
             Path::new("release-plz.toml"),
             Path::new(".release-plz.toml"),
-        ])? {
-            Some((config, path)) => (config, path),
-            None => {
-                info!("release-plz config file not found, using default configuration");
-                return Ok(Config::default());
-            }
+        ])?;
+        if let Some(project_manifest) = project_manifest
+            .or(Some(Path::new(CARGO_TOML)))
+            .filter(|v| v.exists())
+        {
+            return match parse_config_from_metadata(cargo_metadata)? {
+                Some(config) => {
+                    if file_contents.is_some() {
+                        return Err(anyhow::anyhow!(
+                            "configuration is both specified as file and metadata"
+                        ));
+                    }
+                    info!(
+                        "using configuration from metadata in {:?}",
+                        project_manifest
+                    );
+                    Ok(config)
+                }
+                None => Ok(Config::default()),
+            };
+        }
+        if let Some((config, path)) = file_contents {
+            (config, path)
+        } else {
+            info!("release-plz config file not found, using default configuration");
+            return Ok(Config::default());
         }
     };
 
     info!("using release-plz config file {}", path.display());
     toml::from_str(&config).with_context(|| format!("invalid config file {config_path:?}"))
 }
 
+fn parse_config_from_metadata(metadata: &Metadata) -> anyhow::Result<Option<Config>> {
+    // check both workspace and package metadata
+    for metadata in [
+        Some(metadata.clone().workspace_metadata),
+        metadata.packages.first().map(|v| v.metadata.clone()),
+    ]
+    .into_iter()
+    .filter(|v| v.clone().is_some_and(|v| !v.is_null()))
+    {
+        if let Some(metadata) = metadata
+            // safe to unwrap() since it is checked above
+            .unwrap()
+            .as_object()
+            .ok_or_else(|| anyhow::anyhow!("failed to convert metadata to object"))?
+            .get("release-plz")
+        {
+            let config: Config = serde_json::from_value(metadata.clone())
+                .context("failed to parse config from metadata")?;
+            return Ok(Some(config));
+        }
+    }
+    Ok(None)
+}
+
 /// Returns the contents of the first file that exists.
 ///
 /// If none of the files exist, returns `Ok(None)`.

crates/release_plz/src/args/release.rs

@@ -1,5 +1,6 @@
 use std::path::{Path, PathBuf};
 
+use cargo_metadata::Metadata;
 use clap::{
     builder::{NonEmptyStringValueParser, PathBufValueParser},
     ValueEnum,
@@ -71,8 +72,12 @@ pub enum ReleaseGitBackendKind {
 }
 
 impl Release {
-    pub fn config(&self) -> anyhow::Result<Config> {
-        super::parse_config(self.config.as_deref())
+    pub fn config(&self, cargo_metadata: &Metadata) -> anyhow::Result<Config> {
+        super::parse_config(
+            self.config.as_deref(),
+            self.optional_project_manifest(),
+            cargo_metadata,
+        )
     }
 
     pub fn release_request(

crates/release_plz/src/args/update.rs

@@ -1,6 +1,7 @@
 use std::path::{Path, PathBuf};
 
 use anyhow::Context;
+use cargo_metadata::Metadata;
 use chrono::NaiveDate;
 use clap::builder::{NonEmptyStringValueParser, PathBufValueParser};
 use git_cliff_core::config::Config as GitCliffConfig;
@@ -101,8 +102,12 @@ impl RepoCommand for Update {
 }
 
 impl Update {
-    pub fn config(&self) -> anyhow::Result<Config> {
-        super::parse_config(self.config.as_deref())
+    pub fn config(&self, cargo_metadata: &Metadata) -> anyhow::Result<Config> {
+        super::parse_config(
+            self.config.as_deref(),
+            self.optional_project_manifest(),
+            cargo_metadata,
+        )
     }
 
     fn dependencies_update(&self, config: &Config) -> bool {

crates/release_plz/src/main.rs

@@ -27,14 +27,14 @@ async fn run(args: CliArgs) -> anyhow::Result<()> {
     match args.command {
         Command::Update(cmd_args) => {
             let cargo_metadata = cmd_args.cargo_metadata()?;
-            let config = cmd_args.config()?;
+            let config = cmd_args.config(&cargo_metadata)?;
             let update_request = cmd_args.update_request(config, cargo_metadata)?;
             let updates = release_plz_core::update(&update_request)?;
             println!("{}", updates.0.summary());
         }
         Command::ReleasePr(cmd_args) => {
             let cargo_metadata = cmd_args.update.cargo_metadata()?;
-            let config = cmd_args.update.config()?;
+            let config = cmd_args.update.config(&cargo_metadata)?;
             let pr_labels = config.workspace.pr_labels.clone();
             let pr_draft = config.workspace.pr_draft;
             let update_request = cmd_args.update.update_request(config, cargo_metadata)?;
@@ -51,7 +51,7 @@ async fn run(args: CliArgs) -> anyhow::Result<()> {
         }
         Command::Release(cmd_args) => {
             let cargo_metadata = cmd_args.cargo_metadata()?;
-            let config = cmd_args.config()?;
+            let config = cmd_args.config(&cargo_metadata)?;
             let request: ReleaseRequest = cmd_args.release_request(config, cargo_metadata)?;
             release_plz_core::release(&request).await?;
         }

crates/release_plz/tests/all/changelog.rs

@@ -41,3 +41,15 @@ async fn release_plz_releases_a_new_project() {
 
     assert_eq!(packages().len(), 1);
 }
+
+#[tokio::test]
+#[cfg_attr(not(feature = "docker-tests"), ignore)]
+async fn release_plz_uses_config_from_manifest() {
+    let context = TestContext::new().await;
+    context.disable_changelog_update();
+
+    context.run_release_pr().success();
+
+    let opened_prs = context.opened_release_prs().await;
+    assert_eq!(opened_prs.len(), 0);
+}

crates/release_plz/tests/all/helpers/test_context.rs

@@ -92,6 +92,17 @@ impl TestContext {
             .assert()
     }
 
+    pub fn disable_changelog_update(&self) {
+        let cargo_toml_path = self.repo_dir().join("Cargo.toml");
+        let mut cargo_toml = LocalManifest::try_new(&cargo_toml_path).unwrap();
+        cargo_toml.data["workspace"]["metadata"]["release-plz"]["workspace"]["changelog_update"] =
+            toml_edit::Item::Value(toml_edit::Value::Boolean(toml_edit::Formatted::new(false)));
+
+        cargo_toml.write().unwrap();
+        let repo = Repo::new(self.repo_dir()).unwrap();
+        repo.add_all_and_commit("Disable changelog update").unwrap();
+    }
+
     pub fn repo_dir(&self) -> PathBuf {
         self.test_dir.path().join(&self.gitea.repo)
     }
@@ -115,6 +126,8 @@ fn commit_cargo_init(repo_dir: &Path, gitea: &GiteaContext) -> Repo {
     // set email
     repo.git(&["config", "user.email", "a@example.com"])
         .unwrap();
+    // disable gpg signing
+    repo.git(&["config", "commit.gpgsign", "false"]).unwrap();
 
     create_cargo_config(repo_dir, username);