Upgrade projects to SDK style

[robertcoltheart]

This PR upgrades all the projects to use the newer csproj format.

Most of the changes are:

• Pre-processor params around .NET Framework-only code (datalink, dynamic, formatdetector etc)
• Getting the tests working with no T4 transforms
• Some test classes completely deleted as they weren't being included in the original csproj anyway
• Updating and simplifying the build scripts. Everything just passes through dotnet CLI now.

One caveat is that I've dropped out the FileHelpers.Examples project from the solution, otherwise the change count on this PR would skyrocket. Added it back, though it doesn't really work, and didn't seem to work in the old version either.

[robertcoltheart]

This class is to replace the T4 transforms. It's far from ideal, but was necessary to keep the PR file change low. This should be refactored to return strongly typed objects in the future and drop the use of dynamic.

[mcavigelli]

I don't know how to fix this at the moment.
It seems the generated file is still around: GenerateTestData.autogen.cs I believe it is not of any use any more, isn't it?

[mcavigelli]

I have seen that now there are 689 tests with .Net Framework. Before your change there were only 591 tests.
Do you know why that is?

[mcavigelli]

Hi Robert

Thank you for your pullrequest.
I will look into it next weekend.

Matthias

[mcavigelli]

Unfortunately it does not work yet on my machine.
I get compilation errors, saying that global::System.Runtime.Versioning.TargetFrameworkAttribute is declared twice.

I will continue this week.

Matthias

[robertcoltheart]

@mcavigelli My guess is that you need to clear your bin and obj folders for the compilation to work? I double checked and the build definitely works on my machine as well as on the build server.

[mcavigelli]

After cleaning with git clean -dxf and the corrected framework it compiles within no time!
Thank you.

Looking at the created artifacts by appveyor
https://ci.appveyor.com/project/MarcosMeli/filehelpers/builds/37541720/artifacts
it seems that

• FileHelpers netstandard and FileHelpers.Excel do not contain the xml documentation file
• FileHelpers.Excel nuget information is not based on the information in the git repository. Therefore the version number is not correct and other relevant information is not included. But in FileHelpers nuget package it is correctly included.

[mcavigelli]

This looks really like a lot of work you have done for the project!

Thanks a lot Robert.

[mcavigelli]

Regarding the Examples project I am thinking how to rewrite / refactor it with standard means,
ie run it with NUnit, document it with markdown files and building the webpages with docfx.

[robertcoltheart]

@MarcosMeli Fixed all of the above. I modified the Appveyor script to use GitVersion which calculates the SemVer from the git repo tags. So that when you create a release in GitHub, the tag should build on Appveyor and will produce nuget packages that have the tag version. There's probably a way to do it using Appveyor itself, but I don't know Appveyor very well.