Support OAuth 2 #2469
Merged
Support OAuth 2 #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpoole
force-pushed
the
oauth2
branch
2 times, most recently
from
1f6e56b
to
278031b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/de/blau/android/resources/KeyDatabaseHelper.java
Dismissed
Show dismissed
Hide dismissed
This adds a minimal implementation of OAuth 2 that works (likely only) with the current OpenStreetMap API. Fixes #2401
There seems to be some differences in behaviour that cause singleTask mode to not work reliably. Fixes #2470
Note that existing installs will have to migrate manually, this because we don't want to surprise users potentially outside with a request to login to their OSM account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minimal implementation of OAuth 2 as that works (likely only) with the current OpenStreetMap API.
Fixes #2401