Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a direction indicator and allow easy entry of direction values #2559

Merged
merged 8 commits into from
May 22, 2024

Conversation

simonpoole
Copy link
Collaborator

@simonpoole simonpoole commented May 11, 2024

Currently this supports direction, camera:direction and lamp:direction direction entering support for nodes via the property editor and magnetic compass, and new, additionally to ways, support for rotating vie dragging for both individual nodes, multiple elements and multi-polygons.

Resolves #2364

Resolves #1682

Resolves #1157

@simonpoole simonpoole force-pushed the indicate_and_enter_direction branch 2 times, most recently from bf2e5b1 to a095334 Compare May 11, 2024 14:17
@simonpoole simonpoole force-pushed the indicate_and_enter_direction branch 2 times, most recently from 440a85e to f9e2157 Compare May 16, 2024 15:28
This adds support for rotating multiple elements, multi-polygons and
rotating individual nodes with direction tags.
@simonpoole simonpoole force-pushed the indicate_and_enter_direction branch from 47cbb92 to 393cc78 Compare May 17, 2024 08:40
@simonpoole simonpoole force-pushed the indicate_and_enter_direction branch from 393cc78 to a9b6773 Compare May 22, 2024 10:40
@simonpoole simonpoole merged commit d3d82f5 into master May 22, 2024
3 checks passed
@simonpoole simonpoole deleted the indicate_and_enter_direction branch May 22, 2024 14:25
@goldfndr
Copy link

s/arroe/arrow/ (Rotating elements help)
[Possibly also s/WS84/WGS84/]

@jajajaneeneenee
Copy link

jajajaneeneenee commented Jul 16, 2024

Both the new direction input option with compass and the arrow display are great!

I noticed a small cosmetic problem in the property editor: If an item contains a direction key with a combo (maybe editable) that contains e.g. display_values="Forward,Backward, ..." then the display_values ​​are no longer taken into account for the display in the property editor - e.g. "forward" and "backward" are now displayed in lowercase (which is somewhat irritating) – I mean after the value was assigned. (As long as the input option with compass is displayed, the display_values are shown.)

I had this case on a node with a traffic_sign=* tag and a custom preset of mine (direction can be forward/backward for nodes on ways – probably the most common case – or a cardinal direction for nodes beside ways).

@simonpoole
Copy link
Collaborator Author

Please open a new issue for new issues, we can't track them in an already closed one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants