Skip to content

Commit

Permalink
Moved semisync from a plugin to normal server
Browse files Browse the repository at this point in the history
Part of MDEV-13073 AliSQL Optimize performance of semisync

Did the following renames to match other similar variables
key_ss_mutex_LOCK_binlog_       > key_LOCK_bing
key_ss_cond_COND_binlog_send_  -> key_COND_binlog_send
COND_binlog_send_              -> COND_binlog_send
LOCK_binlog_                   -> LOCK_binlog

debian/mariadb-server-10.2.install does not install semisync libs.
  • Loading branch information
montywi committed Dec 18, 2017
1 parent 7703064 commit 2e53b96
Show file tree
Hide file tree
Showing 38 changed files with 860 additions and 1,189 deletions.
2 changes: 0 additions & 2 deletions debian/mariadb-server-10.3.install
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ usr/lib/mysql/plugin/locales.so
usr/lib/mysql/plugin/metadata_lock_info.so
usr/lib/mysql/plugin/query_cache_info.so
usr/lib/mysql/plugin/query_response_time.so
usr/lib/mysql/plugin/semisync_master.so
usr/lib/mysql/plugin/semisync_slave.so
usr/lib/mysql/plugin/server_audit.so
usr/lib/mysql/plugin/simple_password_check.so
usr/lib/mysql/plugin/sql_errlog.so
Expand Down
1 change: 0 additions & 1 deletion mysql-test/extra/rpl_tests/rpl_semi_sync.inc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
# Please check all dependent tests after modifying it
#

source include/have_semisync.inc;
source include/not_embedded.inc;
source include/have_innodb.inc;
source include/master-slave.inc;
Expand Down
4 changes: 0 additions & 4 deletions mysql-test/include/have_semisync.inc

This file was deleted.

4 changes: 0 additions & 4 deletions mysql-test/include/have_semisync.opt

This file was deleted.

39 changes: 0 additions & 39 deletions mysql-test/include/install_semisync.inc

This file was deleted.

29 changes: 0 additions & 29 deletions mysql-test/include/uninstall_semisync.inc

This file was deleted.

28 changes: 28 additions & 0 deletions mysql-test/r/mysqld--help.result
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,27 @@ The following options may be given as the first argument:
--rowid-merge-buff-size=#
The size of the buffers used [NOT] IN evaluation via
partial matching
--rpl-semi-sync-master-enabled
Enable semi-synchronous replication master (disabled by
default).
--rpl-semi-sync-master-timeout=#
The timeout value (in ms) for semi-synchronous
replication in the master
--rpl-semi-sync-master-trace-level=#
The tracing level for semi-sync replication.
--rpl-semi-sync-master-wait-no-slave
Wait until timeout when no semi-synchronous replication
slave available (enabled by default).
(Defaults to on; use --skip-rpl-semi-sync-master-wait-no-slave to disable.)
--rpl-semi-sync-master-wait-point=name
Should transaction wait for semi-sync ack after having
synced binlog, or after having committed in storage
engine.. One of: AFTER_SYNC, AFTER_COMMIT
--rpl-semi-sync-slave-enabled
Enable semi-synchronous replication slave (disabled by
default).
--rpl-semi-sync-slave-trace-level=#
The tracing level for semi-sync replication.
--safe-mode Skip some optimize stages (for testing). Deprecated.
--safe-user-create Don't allow new user creation by the user who has no
write privileges to the mysql.user table.
Expand Down Expand Up @@ -1569,6 +1590,13 @@ report-password (No default value)
report-port 0
report-user (No default value)
rowid-merge-buff-size 8388608
rpl-semi-sync-master-enabled FALSE
rpl-semi-sync-master-timeout 10000
rpl-semi-sync-master-trace-level 32
rpl-semi-sync-master-wait-no-slave TRUE
rpl-semi-sync-master-wait-point AFTER_COMMIT
rpl-semi-sync-slave-enabled FALSE
rpl-semi-sync-slave-trace-level 32
safe-user-create FALSE
secure-auth TRUE
secure-file-priv (No default value)
Expand Down
4 changes: 2 additions & 2 deletions mysql-test/suite/perfschema/r/dml_setup_instruments.result
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ wait/synch/mutex/sql/HA_DATA_PARTITION::LOCK_auto_inc YES YES
wait/synch/mutex/sql/LOCK_active_mi YES YES
wait/synch/mutex/sql/LOCK_after_binlog_sync YES YES
wait/synch/mutex/sql/LOCK_audit_mask YES YES
wait/synch/mutex/sql/LOCK_binlog_state YES YES
wait/synch/mutex/sql/LOCK_binlog YES YES
select * from performance_schema.setup_instruments
where name like 'Wait/Synch/Rwlock/sql/%'
and name not in ('wait/synch/rwlock/sql/CRYPTO_dynlock_value::lock')
Expand All @@ -36,6 +36,7 @@ where name like 'Wait/Synch/Cond/sql/%'
'wait/synch/cond/sql/DEBUG_SYNC::cond')
order by name limit 10;
NAME ENABLED TIMED
wait/synch/cond/sql/COND_binlog_send YES YES
wait/synch/cond/sql/COND_flush_thread_cache YES YES
wait/synch/cond/sql/COND_group_commit_orderer YES YES
wait/synch/cond/sql/COND_gtid_ignore_duplicates YES YES
Expand All @@ -45,7 +46,6 @@ wait/synch/cond/sql/COND_prepare_ordered YES YES
wait/synch/cond/sql/COND_queue_state YES YES
wait/synch/cond/sql/COND_rpl_thread YES YES
wait/synch/cond/sql/COND_rpl_thread_pool YES YES
wait/synch/cond/sql/COND_rpl_thread_queue YES YES
select * from performance_schema.setup_instruments
where name='Wait';
select * from performance_schema.setup_instruments
Expand Down
73 changes: 0 additions & 73 deletions mysql-test/suite/rpl/r/rpl_semi_sync_uninstall_plugin.result

This file was deleted.

1 change: 0 additions & 1 deletion mysql-test/suite/rpl/t/rpl_mdev359.test
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
--source include/have_semisync.inc
--source include/not_embedded.inc
--source include/have_debug_sync.inc
--source include/have_binlog_format_mixed_or_statement.inc
Expand Down
1 change: 0 additions & 1 deletion mysql-test/suite/rpl/t/rpl_semi_sync_event.test
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
source include/have_semisync.inc;
source include/not_embedded.inc;
source include/have_innodb.inc;
source include/master-slave.inc;
Expand Down
132 changes: 0 additions & 132 deletions mysql-test/suite/rpl/t/rpl_semi_sync_uninstall_plugin.test

This file was deleted.

1 change: 0 additions & 1 deletion mysql-test/suite/rpl/t/rpl_semi_sync_wait_point.test
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
source include/have_semisync.inc;
source include/not_embedded.inc;
source include/have_innodb.inc;

Expand Down
1 change: 0 additions & 1 deletion mysql-test/suite/rpl/t/semisync_future-7591.test
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
--source include/have_semisync.inc
--source include/master-slave.inc

call mtr.add_suppression("Timeout waiting for reply of binlog*");
Expand Down
1 change: 0 additions & 1 deletion mysql-test/suite/rpl/t/semisync_memleak_4066.test
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#
# MDEV-4066 semisync_master + temporary tables causes memory leaks
#
source include/have_semisync.inc;
source include/have_binlog_format_row.inc;
source include/master-slave.inc;

Expand Down
Loading

0 comments on commit 2e53b96

Please sign in to comment.