MDEV-22459 pam v2 should log an error if auth_pam_tool exec fails

vuvova · vuvova · commit 6adb0d2f7c8c · 2020-05-08T18:20:38.000+02:00
diff --git a/plugin/auth_pam/auth_pam.c b/plugin/auth_pam/auth_pam.c
@@ -90,6 +90,8 @@ static int pam_auth(MYSQL_PLUGIN_VIO *vio, MYSQL_SERVER_AUTH_INFO *info)
     PAM_DEBUG((stderr, "PAM: execute pam sandbox [%s].\n", toolpath));
     (void) execl(toolpath, toolpath, NULL);
     PAM_DEBUG((stderr, "PAM: exec() failed.\n"));
+    my_printf_error(1, "PAM: Cannot execute %s (errno: %M)", ME_ERROR_LOG_ONLY,
+                    toolpath, errno);
     exit(-1);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,8 @@ static int pam_auth(MYSQL_PLUGIN_VIO vio, MYSQL_SERVER_AUTH_INFO info)`
`90`	`90`	`PAM_DEBUG((stderr, "PAM: execute pam sandbox [%s].\n", toolpath));`
`91`	`91`	`(void) execl(toolpath, toolpath, NULL);`
`92`	`92`	`PAM_DEBUG((stderr, "PAM: exec() failed.\n"));`
	`93`	`+ my_printf_error(1, "PAM: Cannot execute %s (errno: %M)", ME_ERROR_LOG_ONLY,`
	`94`	`+ toolpath, errno);`
`93`	`95`	`exit(-1);`
`94`	`96`	`}`
`95`	`97`