Skip to content

Commit

Permalink
MDEV-29913 Assertion `thd->stmt_arena != thd->progress.arena' failed …
Browse files Browse the repository at this point in the history
…in thd_progress_init upon bulk load

- Commit fc31e31(MDEV-8179) doesn't
report the progress of inplace alter completely. It just does only
in row_merge_sort(). Removing the progress report function completely
  • Loading branch information
Thirunarayanan committed Nov 28, 2023
1 parent d9ae582 commit 7081fee
Showing 1 changed file with 0 additions and 27 deletions.
27 changes: 0 additions & 27 deletions storage/innobase/row/row0merge.cc
Expand Up @@ -3324,17 +3324,6 @@ row_merge_sort(
of file marker). Thus, it must be at least one block. */
ut_ad(file->offset > 0);

/* These thd_progress* calls will crash on sol10-64 when innodb_plugin
is used. MDEV-9356: innodb.innodb_bug53290 fails (crashes) on
sol10-64 in buildbot.
*/
#ifndef __sun__
/* Progress report only for "normal" indexes. */
if (!(dup->index->type & DICT_FTS)) {
thd_progress_init(trx->mysql_thd, 1);
}
#endif /* __sun__ */

if (global_system_variables.log_warnings > 2) {
sql_print_information("InnoDB: Online DDL : merge-sorting"
" has estimated " ULINTPF " runs",
Expand All @@ -3343,15 +3332,6 @@ row_merge_sort(

/* Merge the runs until we have one big run */
do {
/* Report progress of merge sort to MySQL for
show processlist progress field */
/* Progress report only for "normal" indexes. */
#ifndef __sun__
if (!(dup->index->type & DICT_FTS)) {
thd_progress_report(trx->mysql_thd, file->offset - num_runs, file->offset);
}
#endif /* __sun__ */

error = row_merge(trx, dup, file, block, tmpfd,
&num_runs, run_offset, stage,
crypt_block, space);
Expand All @@ -3374,13 +3354,6 @@ row_merge_sort(

ut_free(run_offset);

/* Progress report only for "normal" indexes. */
#ifndef __sun__
if (!(dup->index->type & DICT_FTS)) {
thd_progress_end(trx->mysql_thd);
}
#endif /* __sun__ */

DBUG_RETURN(error);
}

Expand Down

0 comments on commit 7081fee

Please sign in to comment.