Skip to content

Commit

Permalink
Fix building aws_key_management on Linux
Browse files Browse the repository at this point in the history
in MYSQL_ADD_PLUGIN, do not add TARGET_LINK_LIBRARIES twice for the LINK_LIBRARIES parameter
It is usually harmless to add libraries twice.

However, aws_key_management uses -Wl,-whole-archive to workaround linker issues on Linux
If libraries are added twice with whole-archive, linking will fail complaining about duplicate symbols
  • Loading branch information
vaintroub committed Apr 6, 2017
1 parent b64910c commit 73c57e2
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cmake/plugin.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,6 @@ MACRO(MYSQL_ADD_PLUGIN)
ENDIF()
ENDIF()

IF(ARG_LINK_LIBRARIES)
TARGET_LINK_LIBRARIES (${target} ${ARG_LINK_LIBRARIES})
ENDIF()
ADD_DEPENDENCIES(${target} GenError ${ARG_DEPENDENCIES})

SET_TARGET_PROPERTIES(${target} PROPERTIES
Expand Down

0 comments on commit 73c57e2

Please sign in to comment.