Skip to content

Commit

Permalink
MDEV-22770 trx_undo_report_rename() fails to release page latches
Browse files Browse the repository at this point in the history
commit f74023b (MDEV-15090)
inadvertently removed a mtr_t::commit() call from
trx_undo_report_rename(), causing an InnoDB hang if
we failed to log a RENAME operation.

It is unclear whether this condition is possible in practice.
The test case involved SET GLOBAL innodb_trx_rseg_n_slots_debug=1
and a failed CREATE TABLE...SELECT, whose error handling would
internally invoke RENAME in InnoDB.
  • Loading branch information
dr-m committed Jun 2, 2020
1 parent fd2b46d commit 804761a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions storage/innobase/trx/trx0rec.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1934,10 +1934,9 @@ dberr_t trx_undo_report_rename(trx_t* trx, const dict_table_t* table)
}
}
}

mtr.commit();
}

mtr.commit();
return err;
}

Expand Down

0 comments on commit 804761a

Please sign in to comment.