Skip to content

Commit

Permalink
MDEV-10917: Warning suggesting that innodb_page_size is experimental …
Browse files Browse the repository at this point in the history
…may be inaccurate

Removed experimental from message.
  • Loading branch information
Jan Lindström committed Oct 29, 2016
1 parent 885577f commit 84ce681
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 10 deletions.
11 changes: 6 additions & 5 deletions storage/innobase/handler/ha_innodb.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3444,15 +3444,16 @@ innobase_init(
}

if (UNIV_PAGE_SIZE != UNIV_PAGE_SIZE_DEF) {
fprintf(stderr,
"InnoDB: Warning: innodb_page_size has been "
"changed from default value %d to %ldd. (###EXPERIMENTAL### "
"operation)\n", UNIV_PAGE_SIZE_DEF, UNIV_PAGE_SIZE);
ib_logf(IB_LOG_LEVEL_INFO,
"innodb_page_size has been "
"changed from default value %d to %ldd.",
UNIV_PAGE_SIZE_DEF, UNIV_PAGE_SIZE);

/* There is hang on buffer pool when trying to get a new
page if buffer pool size is too small for large page sizes */
if (innobase_buffer_pool_size < (24 * 1024 * 1024)) {
fprintf(stderr, "InnoDB: Error: innobase_page_size %lu requires "
ib_logf(IB_LOG_LEVEL_INFO,
"innobase_page_size %lu requires "
"innodb_buffer_pool_size > 24M current %lld",
UNIV_PAGE_SIZE, innobase_buffer_pool_size);
goto error;
Expand Down
12 changes: 7 additions & 5 deletions storage/xtradb/handler/ha_innodb.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3859,17 +3859,19 @@ innobase_init(
}

if (UNIV_PAGE_SIZE != UNIV_PAGE_SIZE_DEF) {
fprintf(stderr,
"InnoDB: Warning: innodb_page_size has been "
"changed from default value %d to %ldd. (###EXPERIMENTAL### "
"operation)\n", UNIV_PAGE_SIZE_DEF, UNIV_PAGE_SIZE);
ib_logf(IB_LOG_LEVEL_INFO,
"innodb_page_size has been "
"changed from default value %d to %ldd.",
UNIV_PAGE_SIZE_DEF, UNIV_PAGE_SIZE);

/* There is hang on buffer pool when trying to get a new
page if buffer pool size is too small for large page sizes */
if (innobase_buffer_pool_size < (24 * 1024 * 1024)) {
fprintf(stderr, "InnoDB: Error: innobase_page_size %lu requires "
ib_logf(IB_LOG_LEVEL_INFO,
"innobase_page_size %lu requires "
"innodb_buffer_pool_size > 24M current %lld",
UNIV_PAGE_SIZE, innobase_buffer_pool_size);

goto error;
}
}
Expand Down

0 comments on commit 84ce681

Please sign in to comment.