Skip to content

Commit

Permalink
Revert "MDEV-30151 parse error 1=2 not between/in"
Browse files Browse the repository at this point in the history
This reverts commit eba0991.

A different patch with less shift-reduce conflicts is coming.
  • Loading branch information
abarkov committed Jan 26, 2023
1 parent 4652260 commit b1043ea
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 25 deletions.
11 changes: 0 additions & 11 deletions mysql-test/main/parser.result
Expand Up @@ -1866,15 +1866,4 @@ ERROR 42000: You have an error in your SQL syntax; check the manual that corresp
EXECUTE IMMEDIATE 'CREATE PROCEDURE p() UPDATE t SET c=\'\'"abc';
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"abc' at line 1
SET @@sql_mode=@save_sql_mode;
#
# MDEV-30151 parse error 1=2 not between/in
#
select 1=2 not in (3,4);
1=2 not in (3,4)
1
select 1=2 not between 3 and 4;
1=2 not between 3 and 4
1
#
# End of 10.3 tests
#
8 changes: 0 additions & 8 deletions mysql-test/main/parser.test
Expand Up @@ -1673,12 +1673,4 @@ EXECUTE IMMEDIATE 'CREATE PROCEDURE p() UPDATE t SET c=\'\'"abc';

SET @@sql_mode=@save_sql_mode;

--echo #
--echo # MDEV-30151 parse error 1=2 not between/in
--echo #
select 1=2 not in (3,4);
select 1=2 not between 3 and 4;

--echo #
--echo # End of 10.3 tests
--echo #
6 changes: 3 additions & 3 deletions sql/sql_yacc.yy
Expand Up @@ -899,7 +899,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);
/*
We should not introduce any further shift/reduce conflicts.
*/
%expect 96
%expect 85

/*
Comments for TOKENS.
Expand Down Expand Up @@ -1687,7 +1687,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);

%left PREC_BELOW_NOT

%nonassoc LOW_PRIORITY_NOT
%nonassoc NOT_SYM
%left '=' EQUAL_SYM GE '>' LE '<' NE
%nonassoc IS
%right BETWEEN_SYM
Expand Down Expand Up @@ -9840,7 +9840,7 @@ expr:
MYSQL_YYABORT;
}
}
| NOT_SYM expr %prec LOW_PRIORITY_NOT
| NOT_SYM expr %prec NOT_SYM
{
$$= negate_expression(thd, $2);
if (unlikely($$ == NULL))
Expand Down
6 changes: 3 additions & 3 deletions sql/sql_yacc_ora.yy
Expand Up @@ -293,7 +293,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);
/*
We should not introduce any further shift/reduce conflicts.
*/
%expect 98
%expect 87

/*
Comments for TOKENS.
Expand Down Expand Up @@ -1081,7 +1081,7 @@ bool my_yyoverflow(short **a, YYSTYPE **b, size_t *yystacksize);

%left PREC_BELOW_NOT

%nonassoc LOW_PRIORITY_NOT
%nonassoc NOT_SYM
%left '=' EQUAL_SYM GE '>' LE '<' NE
%nonassoc IS
%right BETWEEN_SYM
Expand Down Expand Up @@ -9797,7 +9797,7 @@ expr:
MYSQL_YYABORT;
}
}
| NOT_SYM expr %prec LOW_PRIORITY_NOT
| NOT_SYM expr %prec NOT_SYM
{
$$= negate_expression(thd, $2);
if (unlikely($$ == NULL))
Expand Down

0 comments on commit b1043ea

Please sign in to comment.