Skip to content

Commit

Permalink
cleanup: remove *.opt files from the versioning suite
Browse files Browse the repository at this point in the history
use include/have_xxx.inc when some feature needs to be present
(because --xxx in the opt file will fail if the xxx is not compiled in)

set variables in the test, not on the command line, to avoid unnecessary
server restarts (they're must slower than SET).
  • Loading branch information
vuvova committed Feb 23, 2018
1 parent f1bd02d commit f38ef43
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 4 deletions.
1 change: 1 addition & 0 deletions mysql-test/suite/versioning/r/partition.result
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
set system_versioning_alter_history=keep;
# Check conventional partitioning on temporal tables
create table t1 (x int)
with system versioning
Expand Down
1 change: 0 additions & 1 deletion mysql-test/suite/versioning/t/partition.opt

This file was deleted.

1 change: 1 addition & 0 deletions mysql-test/suite/versioning/t/partition.test
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
-- source include/have_partition.inc
-- source suite/versioning/common.inc

set system_versioning_alter_history=keep;
--echo # Check conventional partitioning on temporal tables

create table t1 (x int)
Expand Down
1 change: 0 additions & 1 deletion mysql-test/suite/versioning/t/truncate.opt

This file was deleted.

1 change: 1 addition & 0 deletions mysql-test/suite/versioning/t/truncate.test
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
--source include/have_partition.inc
--source suite/versioning/engines.inc

create table t (a int);
Expand Down
1 change: 0 additions & 1 deletion mysql-test/suite/versioning/t/vtmd.opt

This file was deleted.

2 changes: 2 additions & 0 deletions mysql-test/suite/versioning/t/vtmd.test
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
-- source include/have_innodb.inc
set default_storage_engine=innodb;

delimiter ~~;
create or replace procedure drop_archives (in vtmd_name varchar(64))
begin
Expand Down
1 change: 0 additions & 1 deletion mysql-test/suite/versioning/t/vtmd_show.opt

This file was deleted.

2 changes: 2 additions & 0 deletions mysql-test/suite/versioning/t/vtmd_show.test
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
-- source include/have_innodb.inc

delimiter ~~;
create or replace procedure drop_archives (in vtmd_name varchar(64))
begin
Expand Down

0 comments on commit f38ef43

Please sign in to comment.