Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not break main configuration with instantiated one #1095

Closed
wants to merge 1 commit into from

Conversation

eworm-de
Copy link
Contributor

The main configuration file /etc/my.cnf includes all configuration files in
/etc/my.cnf.d/. However an instantiated service mariadb@example.service
reads its configuration from /etc/my.cnf.d/myexample.cnf. This breaks
the main configuration as that includes a snippet intended for an instance.

This can be fixed by changing the path: Let the instantiated service
read its configuration from /etc/myexample.cnf.

@an3l an3l added this to the 10.4 milestone Jan 15, 2019
@an3l
Copy link
Contributor

an3l commented Jan 15, 2019

Hi @eworm-de
Thanks for your contribution.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license.

The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/

Please indicate in a comment below, or update your PR comment that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
Anel

@eworm-de
Copy link
Contributor Author

I have filled out the contribution agreement and sent it.

@an3l
Copy link
Contributor

an3l commented Jan 15, 2019

Thanks

@an3l an3l added the license-mca Contributed under the MCA label Jan 15, 2019
@grooverdan
Copy link
Member

I submitted a similar fix for this in #510.

@eworm-de
Copy link
Contributor Author

Oh well, this one is more than a year old...

@grooverdan
Copy link
Member

yes - 😞 😿

@eworm-de eworm-de changed the base branch from 10.4 to 10.3 January 29, 2019 19:19
@eworm-de
Copy link
Contributor Author

eworm-de commented Feb 7, 2019

BTW, this is in Arch Linux package since update to 10.3.x:
0004-do-not-break-main-configuration-with-instantiated-one.patc

The main configuration file /etc/my.cnf includes all configuration files in
/etc/my.cnf.d/. However an instantiated service mariadb@example.service
reads its configuration from /etc/my.cnf.d/myexample.cnf. This breaks
the main configuration as that includes a snippet intended for an instance.

This can be fixed by changing the path: Let the instantiated service
read its configuration from /etc/myexample.cnf.
@eworm-de
Copy link
Contributor Author

Closing now that #510 is merged.

@eworm-de eworm-de closed this Jun 21, 2019
@eworm-de eworm-de deleted the instantiated-service branch February 14, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
license-mca Contributed under the MCA
4 participants