Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDEV-18374: Add SELinux policy to cracklib_password_check packages #1131

Merged
merged 1 commit into from Jul 26, 2023
Merged

MDEV-18374: Add SELinux policy to cracklib_password_check packages #1131

merged 1 commit into from Jul 26, 2023

Conversation

GeoffMontee
Copy link
Contributor

No description provided.

@an3l an3l added this to the 10.1 milestone Jan 25, 2019
@janlindstrom janlindstrom removed their assignment Feb 14, 2019
@svoj svoj assigned vuvova and unassigned vaintroub Apr 4, 2019
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

SergMariaDB
SergMariaDB reviewed Oct 21, 2021
View reviewed changes
...n/cracklib_password_check/support-files/rpm/mariadb-plugin-cracklib-password-check-postin.sh
SECONPROG=$SETARGETDIR/file_contexts/program

if [ -x /usr/sbin/semodule ] ; then
/usr/sbin/semodule -i /usr/share/mysql/policy/selinux/mariadb-plugin-cracklib-password-check.pp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the mariadb-plugin-cracklib-password-check.pp located?

@LinuxJedi
Copy link
Contributor

Hi @GeoffMontee,

I'm currently working on assisting in getting older pull requests moving along where I can. If this one is still needed can you please rebase it against either 10.3 or 10.11 so that we can get it moving. Also if you could please answer Sergei's question that will also help.

Many thanks!

@LinuxJedi LinuxJedi changed the base branch from 10.1 to 10.4 July 25, 2023 16:31
@GeoffMontee
Copy link
Contributor Author

Hi @SergMariaDB and @LinuxJedi,

Sorry, I missed your previous comments on this. It has been a while since I looked at this PR, but I believe the mariadb-plugin-cracklib-password-check.pp file is constructed from the mariadb-plugin-cracklib-password-check.te file using the commands in MDEV-18374:

sudo yum install selinux-policy-devel
make -f /usr/share/selinux/devel/Makefile mariadb-plugin-cracklib-password-check.pp
sudo semodule -i mariadb-plugin-cracklib-password-check.pp

It looks kind of like I forgot to include the make call in my PR.

Do you still want me to try to look into this?

@grooverdan
Copy link
Member

Actually looks fine to me. CMake explictly shows the .pp generated by custom command and the CI shows

[ 11%] Generating mariadb-plugin-cracklib-password-check.pp

So looks good to me.

@LinuxJedi
Copy link
Contributor

Agreed, I was going to approve it, the CMake you used does generate it.

@LinuxJedi LinuxJedi merged commit 23dae61 into MariaDB:10.4 Jul 26, 2023
11 checks passed
@GeoffMontee
Copy link
Contributor Author

Thanks guys!

robinnewhouse added a commit to robinnewhouse/mariadb-server that referenced this pull request Jan 26, 2024
@robinnewhouse
Fix ninja build for cracklib_password_check
39cafec 
As was done in dc77111 for `support-files/CMakeLists.txt`
Do not rely on existence of `CMakeFiles/${target}.dir` directory
existence. It is not there for custom targets in Ninja build.

This regression was introduced in MariaDB#1131 which likely copied the pattern
from e79e840 before that regression was addressed in dc77111.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services.
robinnewhouse added a commit to robinnewhouse/mariadb-server that referenced this pull request Jan 26, 2024
@robinnewhouse
Fix ninja build for cracklib_password_check
c649d78 
As was done in dc77111 for `support-files/CMakeLists.txt`
Do not rely on existence of `CMakeFiles/${target}.dir` directory
existence. It is not there for custom targets in Ninja build.

This regression was introduced in MariaDB#1131 which likely copied the pattern
from e79e840 before that regression was addressed in dc77111.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services.
@robinnewhouse robinnewhouse mentioned this pull request Jan 26, 2024
Merged
3 tasks
ottok pushed a commit to robinnewhouse/mariadb-server that referenced this pull request Feb 7, 2024
@robinnewhouse @ottok
Fix ninja build for cracklib_password_check
191075d 
As was done in dc77111 for `support-files/CMakeLists.txt`
Do not rely on existence of `CMakeFiles/${target}.dir` directory
existence. It is not there for custom targets in Ninja build.

This regression was introduced in MariaDB#1131 which likely copied the pattern
from e79e840 before that regression was addressed in dc77111.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services.
robinnewhouse added a commit to robinnewhouse/mariadb-server that referenced this pull request Feb 7, 2024
@robinnewhouse
Fix ninja build for cracklib_password_check
81b7716 
As was done in dc77111 for `support-files/CMakeLists.txt`
Do not rely on existence of `CMakeFiles/${target}.dir` directory
existence. It is not there for custom targets in Ninja build.

This regression was introduced in MariaDB#1131 which likely copied the pattern
from e79e840 before that regression was addressed in dc77111.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services.
robinnewhouse added a commit to robinnewhouse/mariadb-server that referenced this pull request Feb 7, 2024
@robinnewhouse
Fix ninja build for cracklib_password_check
253547a 
As was done in dc77111 for `support-files/CMakeLists.txt`
Do not rely on existence of `CMakeFiles/${target}.dir` directory
existence. It is not there for custom targets in Ninja build.

This regression was introduced in MariaDB#1131 which likely copied the pattern
from e79e840 before that regression was addressed in dc77111.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services.
grooverdan pushed a commit that referenced this pull request Feb 8, 2024
@robinnewhouse @grooverdan
Fix ninja build for cracklib_password_check
68c0f6d 
As was done in dc77111 for `support-files/CMakeLists.txt`
Do not rely on existence of `CMakeFiles/${target}.dir` directory
existence. It is not there for custom targets in Ninja build.

This regression was introduced in #1131 which likely copied the pattern
from e79e840 before that regression was addressed in dc77111.

All new code of the whole pull request, including one or several files
that are either new files or modified ones, are contributed under the
BSD-new license. I am contributing on behalf of my employer Amazon Web
Services.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergMariaDB SergMariaDB SergMariaDB left review comments

@grooverdan grooverdan grooverdan approved these changes

Assignees

@vuvova vuvova

Labels
MariaDB Corporation
Milestone
10.1
9 participants
@GeoffMontee @CLAassistant @LinuxJedi @grooverdan @SergMariaDB @vaintroub @vuvova @janlindstrom @an3l