Fix for MDEV-8206, as per Jira comments of 2015-11-16 and 2015-11-30

[pastcompute]

No description provided.

[svoj]

Hi Andrew,

Thanks for your contribution. JIRA task link just for the record: https://mariadb.atlassian.net/browse/MDEV-8206

This task was added to 10.0.24 backlog, which is planned to be handled between 2016-02-10 and 2016-02-17.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license.

The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/

Please indicate in a comment below that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
Sergey

[pastcompute]

Hi Sergey,

would I have done something like this already? (I have had previous work
accepted into MariaDB) or is this a new procedure?

Note, at present, oqgraph is GPL2 ...

cheers,
Andrew

On 2016-01-29 01:24, Sergey wrote:

Hi Andrew,

Thanks for your contribution. JIRA task link just for the record:
https://mariadb.atlassian.net/browse/MDEV-8206 [1]

This task was added to 10.0.24 backlog, which is planned to be handled
between 2016-02-10 and 2016-02-17.

Similar to other open source projects, the MariaDB Foundation needs to
have shared ownership of all code that is included in the MariaDB
distribution. The easiest way to achieve this is by submitting your
code under the BSD-new license.

The other alternative is to sign the code contribution agreement which
can be found here: https://mariadb.com/kb/en/mariadb/mca/ [2]

Please indicate in a comment below that you are contributing your new
code of the whole pull request, including one or several files that
are either new files or modified ones, under the BSD-new license or
that you have filled out the contribution agreement and sent it.

Thanks,
Sergey

Reply to this email directly or view it on GitHub [3].

Links:

[1] https://mariadb.atlassian.net/browse/MDEV-8206
[2] https://mariadb.com/kb/en/mariadb/mca/
[3] #153 (comment)

--Andrew

Twitter: @andymc73
http://blog.oldcomputerjunk.net

[svoj]

Hi Andrew,

you're right. As soon as you didn't change anything but the engine (and you're the owner of the engine) you don't need to clarify the license.

Thanks,
Sergey

[svoj]

I'd suggest to use ha_thd() instead of current_thd here as it normally returns table->in_use, which is cheaper than current_thd.

The trace Elena provided is generated by debug build. In release build tc_acquire_table() won't call this particular extra(HA_EXTRA_IS_ATTACHED_CHILDREN). The question is what if we call another handler method before calling any extra() in release build? Though I didn't check if that's the case.

[pastcompute]

Hi @svoj thanks for the suggestion, TBH I never quite got a handle on all of the interfaces when I ported this code from mariadb5 and had to muddle through
I wont be able to push this until next week though I'm away atm

[pastcompute]

@svoj addresses previous comment re current_thd

[vuvova]

Merged. Will push shortly