Fix my_print_default client #1566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase had too many merge conflicts, redo on 5.5
|
Probably |
|
Checked out the situation in deb packages: my_print_defaults is part of the mariadb-server-10.5 package and used among others by the logrotate script (until #1556 removes it). The mariadb-server-10.5 package depends on mariadb-client-10.5 so the change should be OK. |
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Jun 5, 2020
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: MariaDB#1566
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Jun 5, 2020
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: MariaDB#1566
an3l
pushed a commit
that referenced
this pull request
Jun 6, 2020
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566
an3l
pushed a commit
that referenced
this pull request
Jun 6, 2020
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566 Closes 1581
an3l
pushed a commit
that referenced
this pull request
Aug 2, 2020
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566 Closes 1581
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Aug 7, 2020
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: MariaDB#1566
an3l
pushed a commit
that referenced
this pull request
Mar 17, 2021
an3l
added a commit
that referenced
this pull request
Mar 17, 2021
an3l
pushed a commit
that referenced
this pull request
Mar 17, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566 Closes PR #1581
grooverdan
pushed a commit
that referenced
this pull request
Mar 18, 2021
grooverdan
pushed a commit
that referenced
this pull request
Mar 18, 2021
grooverdan
pushed a commit
that referenced
this pull request
Mar 18, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566 Closes PR #1581
grooverdan
pushed a commit
that referenced
this pull request
Mar 18, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566 Closes PR #1581
grooverdan
pushed a commit
that referenced
this pull request
Mar 19, 2021
grooverdan
pushed a commit
that referenced
this pull request
Mar 19, 2021
grooverdan
pushed a commit
that referenced
this pull request
Mar 19, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566 Closes PR #1581
grooverdan
pushed a commit
that referenced
this pull request
Mar 28, 2021
grooverdan
pushed a commit
that referenced
this pull request
Mar 28, 2021
grooverdan
pushed a commit
that referenced
this pull request
Mar 28, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Related: #1566 Closes PR #1581
|
Thanks pushed with 4f8945e on |
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Apr 2, 2021
There are many programs that actually belong to the client or even client core package, as they should be fully usable without a locally installed server. Examples: - The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Closes: MariaDB#1566, MariaDB#1581 (both PRs to move my_print_defaults)
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Apr 4, 2021
There are many programs that actually belong to the client or even client core package, as they should be fully usable without a locally installed server. Examples: - The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_deafult is always available when mytop is installed. The my_print_defaults is also required by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Closes: MariaDB#1566, MariaDB#1581 (both PRs to move my_print_defaults)
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Apr 4, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_default is always available when mytop is installed. The my_print_defaults is also requires by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Closes: MariaDB#1566, MariaDB#1581
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Apr 11, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_default is always available when mytop is installed. The my_print_defaults is also requires by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Closes: MariaDB#1566, MariaDB#1581
ottok
added a commit
to ottok/mariadb
that referenced
this pull request
Apr 15, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_default is always available when mytop is installed. The my_print_defaults is also requires by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Closes: MariaDB#1566, MariaDB#1581
grooverdan
pushed a commit
that referenced
this pull request
Apr 16, 2021
The my_print_default is required by mytop which is also in the MariaDB client package, which in turn requires the client core package. This way it is ensured my_print_default is always available when mytop is installed. The my_print_defaults is also requires by the server logrotate files and mysqld_safe script etc, but this change is fine, since the server core package always depends on the MariaDB client core package anyway and they are both installed on server installations. Closes: #1566, #1581
an3l
pushed a commit
to an3l/server
that referenced
this pull request
Jun 23, 2021
Make `my_print_defaults` a client app (required by `mytop`). Closes MariaDB#1566 Reviewed by: serg@mariadb.com, anel@mariadb.org
an3l
pushed a commit
to an3l/server
that referenced
this pull request
Oct 25, 2021
Make `my_print_defaults` a client app (required by `mytop`). Closes MariaDB#1566 Reviewed by: serg@mariadb.com, anel@mariadb.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my_print_default is a client app, it is required by scripts/mytop