Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDEV-12130: Add break statement in mysqltest #1580

Merged
merged 2 commits into from Sep 14, 2023
Merged

MDEV-12130: Add break statement in mysqltest #1580

merged 2 commits into from Sep 14, 2023

Conversation

DwarfMason
Copy link
Contributor

I've added break statement to mysqltest.cc to improve flexibility of test framework.

@CLAassistant
Copy link

CLAassistant commented Jun 5, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@an3l an3l added this to the 10.5 milestone Jun 5, 2020
FooBarrior
FooBarrior requested changes Jun 6, 2020
View reviewed changes
client/mysqltest.cc Outdated Show resolved Hide resolved
@DwarfMason DwarfMason force-pushed the 10.5 branch 7 times, most recently from 1fe707e to aa851df Compare June 8, 2020 08:13
vuvova
vuvova requested changes Jun 8, 2020
View reviewed changes
Copy link
Member

@vuvova vuvova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Few comments re. tests

client/mysqltest.cc Show resolved Hide resolved
mysql-test/main/mysqltest-break.test Outdated Show resolved Hide resolved
mysql-test/main/mysqltest-break.test Outdated Show resolved Hide resolved
@DwarfMason DwarfMason requested a review from vuvova June 9, 2020 07:10
@DwarfMason DwarfMason changed the title Add break statement in mysqltest MDEV-12130: Add break statement in mysqltest Jun 9, 2020
DanAtSPB
DanAtSPB reviewed Jun 15, 2020
View reviewed changes
client/mysqltest.cc Outdated Show resolved Hide resolved
@robertbindar robertbindar self-assigned this Dec 16, 2021
@LinuxJedi LinuxJedi assigned LinuxJedi and unassigned robertbindar Sep 12, 2023
LinuxJedi
LinuxJedi approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, comments have been addressed. Approved for 11.3.

@LinuxJedi LinuxJedi changed the base branch from 10.5 to 11.3 September 13, 2023 14:21
@LinuxJedi
Update mysqltest-break.test
3c35a60 
This test does not work in embedded and I cannot see an obvious way of fixing that. The test not running in embedded is not the end of the world here.
@LinuxJedi LinuxJedi merged commit 8d9bc61 into MariaDB:11.3 Sep 14, 2023
13 checks passed
@FooBarrior
Copy link
Contributor

FooBarrior commented Sep 15, 2023 •
edited

@LinuxJedi Thanks for making a kick to this one. Why 11.3? We usually update our testing framework beginning from the lowest alive version.

@FooBarrior FooBarrior mentioned this pull request Sep 15, 2023
Open
@LinuxJedi
Copy link
Contributor

@LinuxJedi Thanks! Thenks for making a kick to this one. Why 11.3? We usually update our testing framiwork beginning from the lowest alive version.

I saw it as a new feature, hence 11.3. I wasn't aware of the testing framework features going to lowest. Please feel free to backport. I'll add #1585 to my list to take a look at :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanAtSPB DanAtSPB DanAtSPB left review comments

@LinuxJedi LinuxJedi LinuxJedi approved these changes

@FooBarrior FooBarrior Awaiting requested review from FooBarrior

@vuvova vuvova Awaiting requested review from vuvova

Assignees

@FooBarrior FooBarrior

@LinuxJedi LinuxJedi

Labels
None yet
Milestone
10.5
8 participants
@DwarfMason @CLAassistant @FooBarrior @LinuxJedi @vuvova @DanAtSPB @robertbindar @an3l