MDEV-28645: Reword MariaDB 10.9 Salsa-CI file and add upgrade test from 10.8 #2133
Conversation
There was a problem hiding this comment.
Thanks! Adding a test for upgrades of 10.8 is useful, and unifying naming scheme is a good cleanup to do.
However, using mariadb.org-10.7 to mariadb 10.9 upgrade: would mean that when merging Salsa-CI changes across versions we would need to keep bumping that 10.9 and the time? And this test always runs on a specific branch, so maybe mentioning the target name is redundant? How about using a naming scheme like upgrade from mariadb.org-10.7:? Then we don't need to name the target, as the target is always the commit in question. Or even simpler, just call it upgrade mariadb.org-10.7:?
We should think this through as once we do this change, we should do the same change everywhere to unify the naming, and we don't want to flip the name back and forth.
Tangenting the cleanup, lines like 'service mariadb status # There is no init.d/mysql in MariaDB 10.XXX should always say 'service mariadb status # There is no init.d/mysql in MariaDB 10.5+ and not have the 10.5+ change on merges on newer branches, as the comment is about MariaDB release changes, not any branch specific stuff.
Diff of current 10.6 Salsa-CI in Debian vs upstream MariaDB/server: https://paste.ubuntu.com/p/GR832ZHbPK/
illuusio
force-pushed
the
10.9-MDEV-28645-reword-salsaci-file
branch
2 times, most recently
from
5ec7dfe
to
b65c614
Compare
|
Made suggested changes and add test for 10.9. Salsa-CI pipeline can be found on: |
illuusio
force-pushed
the
10.9-MDEV-28645-reword-salsaci-file
branch
from
b65c614
to
ba972b4
Compare
Correct some Salsa-CI upgrade test topics that are wrong (like having mariadb-10.8 in name) and reword them to look similar MariaDB 10.9 Salsa-CI file is missing upgrade test from 10.8 and also upon 10.9. Add it to Salsa-CI file be congruence.
LinuxJedi
force-pushed
the
10.9-MDEV-28645-reword-salsaci-file
branch
from
ba972b4
to
df138c6
Compare
Description
Currently Salsa-CI upgrade topic are bit misleading and incorrect. This PR correct them and adds upgrade test from 10.8
How can this PR be tested?
Check upgrading topics on Salsa-CI run:
https://salsa.debian.org/illuusio/mariadb-server/-/pipelines/384409
Basing the PR against the correct MariaDB version
Backward compatibility
Nothing this more linting than anything. Does not change behavior or adds more as 10.8 upgrading is tested.