Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-10750 - travis: gcc-5 and gcc-6 #220

Merged
merged 2 commits into from Dec 15, 2016
Merged

Conversation

grooverdan
Copy link
Member

depends on no_ipv6 PR to succeed.

I submit this under the MCA.

@svoj
Copy link

svoj commented Aug 24, 2016

@grooverdan, thanks for your contribution!

@ottok, could you handle this PR?

@ottok
Copy link
Contributor

ottok commented Sep 6, 2016

Thanks @grooverdan ! Unfortunately the test suite failed. Should you force push a fixed version before anybody reviews the details?

@svoj Please assign this to yourself, I have no particular domain knowledge about GCC versions or how they affect MariaDB.

@svoj
Copy link

svoj commented Sep 6, 2016

Hi Daniel,

Thanks for your contribution. JIRA task has been created to track this pull request: https://jira.mariadb.org/browse/MDEV-10750

This task was added to 10.2.3 backlog, which is planned to be handled between 2016-09-22 and 2016-09-29.

Thanks,
Sergey

@svoj svoj changed the title travis: gcc-5 and gcc-6 MDEV-10750 - travis: gcc-5 and gcc-6 Sep 6, 2016
@svoj
Copy link

svoj commented Sep 6, 2016

@ottok, FWICS test suite failure doesn't relate to this PR. Also I believe this PR is properply assigned: you have best domain knowledge of Travis, current Travis configuration is yours too.

@grooverdan, what was the rationale of this PR?

@grooverdan
Copy link
Member Author

rational is to test against modern a variety of gcc version, particularly later versions, to ensure that warnings or errors can be corrected as code gets developed. This makes the code merged future resistant and reduces the development burden by avoid revisiting and re-factoring code in 6+ months when some user tries it against a modern gcc version.

@grooverdan
Copy link
Member Author

@cvicentiu , have the gcc-6 issues related to this pointers been resolved?

@svoj
Copy link

svoj commented Dec 14, 2016

@grooverdan, is this change still relevant? Does it depend on other PR's?

@grooverdan
Copy link
Member Author

Still relevent. doesn't depend on other PRs.

@svoj svoj merged commit a8e0c6f into MariaDB:10.2 Dec 15, 2016
@grooverdan grooverdan deleted the 10.2-travis_cc branch December 15, 2016 23:52
dr-m pushed a commit that referenced this pull request Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants