Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-10751 - fix ipv6 detection test in MTR (aka make travis work) #223

Closed
wants to merge 1 commit into from

Conversation

grooverdan
Copy link
Member

based on a number of variants in https://travis-ci.org/grooverdan/mariadb-server/builds (10.2-travis_no_ipv6 branch) the current ipv6 detection isn't returning false on travis where there is no IPv6.

Here we do a bind (to the MTR baseport) rather than a connect to test. This seems to work correctly.

I submit this under the MCA.

Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
@grooverdan grooverdan changed the title MDEV-9158: fix ipv6 detection test in MTR MDEV-9185: fix ipv6 detection test in MTR (aka make travis work) Sep 5, 2016
@svoj svoj changed the title MDEV-9185: fix ipv6 detection test in MTR (aka make travis work) MDEV-10751 - fix ipv6 detection test in MTR (aka make travis work) Sep 6, 2016
@svoj
Copy link

svoj commented Sep 6, 2016

Hi Daniel,

Thanks for your contribution. JIRA task has been created to track this pull request: https://jira.mariadb.org/browse/MDEV-10751

This task was added to 10.2.3 backlog, which is planned to be handled between 2016-09-22 and 2016-09-29.

Thanks,
Sergey

@vuvova
Copy link
Member

vuvova commented Oct 4, 2016

pushed in 10.2, thanks

@vuvova vuvova closed this Oct 4, 2016
@grooverdan
Copy link
Member Author

nice simplification too.

@grooverdan grooverdan deleted the 10.2-travis-fix-no-ipv6 branch October 4, 2016 15:08
@ottok
Copy link
Contributor

ottok commented Oct 4, 2016

Thanks @grooverdan !

@vuvova There is still Failing test(s): main.ssl_ca in your commit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants