Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-10830 - Fix undefined database test error when running mysql_install_db #234

Merged
merged 2 commits into from
Sep 22, 2016

Conversation

seamuslee001
Copy link
Contributor

When using mariaDb in docker mode it can fail as it calls mysql_install_db but as we are going through a slightly different install process the test database has not been created, therefore we should fall back to the mysql database as per https://mariadb.com/kb/en/mariadb/mariadb-10112-mysql_install_db-aborts-on-unkown-file-test/

When using mariaDb in docker mode it can fail as it calls mysql_install_db but as we are going through a slightly different install process the test database has not been created, therefore we should fall back to the mysql database as per https://mariadb.com/kb/en/mariadb/mariadb-10112-mysql_install_db-aborts-on-unkown-file-test/
@svoj svoj changed the title Fix undefined database test error when running mysql_install_db MDEV-10830 - Fix undefined database test error when running mysql_install_db Sep 19, 2016
@svoj
Copy link

svoj commented Sep 19, 2016

Hi Seamus,

Thanks for your contribution. JIRA task has been created to track this pull request: https://jira.mariadb.org/browse/MDEV-10830

This task was added to 10.1.19 backlog, which is planned to be handled between 2016-10-13 and 2016-10-20.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license.

The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/

Please indicate in a comment below that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
Sergey

@seamuslee001
Copy link
Contributor Author

@svoj Hi Sergey, all the code here is just altering a file there. There fore i would assume that it would be under the BSD-new license as its only a 1 line patch. I can fill out the contribution agreement as well if needed.

@holyfoot
Copy link
Contributor

holyfoot commented Sep 22, 2016

I added the patch to 10830 that basically completes this on for the mysql_install_db.pl.in.

HF

On Mon, Sep 19, 2016 at 2:16 PM, Sergey Vojtovich notifications@github.com
wrote:

Hi Seamus,

Thanks for your contribution. JIRA task has been created to track this
pull request: https://jira.mariadb.org/browse/MDEV-10830

This task was added to 10.1.19 backlog, which is planned to be handled
between 2016-10-13 and 2016-10-20.

Similar to other open source projects, the MariaDB Foundation needs to
have shared ownership of all code that is included in the MariaDB
distribution. The easiest way to achieve this is by submitting your code
under the BSD-new license.

The other alternative is to sign the code contribution agreement which can
be found here: https://mariadb.com/kb/en/mariadb/mca/

Please indicate in a comment below that you are contributing your new code
of the whole pull request, including one or several files that are either
new files or modified ones, under the BSD-new license or that you have
filled out the contribution agreement and sent it.

Thanks,
Sergey


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#234 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHjkHoiXTZZxbILBUrb2ZhWmVS0zU3KIks5qrmEKgaJpZM4J9bVy
.

@holyfoot holyfoot merged commit e387bfa into MariaDB:10.1 Sep 22, 2016
dr-m pushed a commit that referenced this pull request Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants