Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDEV-30824] Fix binlog to use 'String' for setting 'character_set_client' #2557

Closed
wants to merge 1 commit into from

Commits on Mar 20, 2023

  1. [MDEV-30824] Fix binlog to use 'String' for setting 'character_set_cl…

    …ient'
    
    Commit a923d6f disabled numeric setting
    of character_set_* variables with non-default values:
    
      MariaDB [(none)]> set character_set_client=224;
      ERROR 1115 (42000): Unknown character set: '224'
    
    However the corresponding binlog functionality still write numeric
    values for log event, and this will break binlog replay if the value is
    not default. Now make the server use 'String' type for
    'character_set_client' when generating binlog events
    
    Before:
    
      /*!\C utf8mb4 *//*!*/;
      SET @@session.character_set_client=224,@@session.collation_connection=224,@@session.collation_server=33/*!*/;
    
    After:
    
      /*!\C utf8mb4 *//*!*/;
      SET @@session.character_set_client=utf8mb4,@@session.collation_connection=33,@@session.collation_server=8/*!*/;
    
    Note: prior to the previous commit, setting with '224' or '45' or
    'utf8mb4' have the same effect, as they all set the parameter to
    'utf8mb4'.
    
    All new code of the whole pull request, including one or several files
    that are either new files or modified ones, are contributed under the
    BSD-new license. I am contributing on behalf of my employer Amazon Web
    Services, Inc.
    PhysicsTing committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    dfa572c View commit details
    Browse the repository at this point in the history