Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-10980: Fix reverse queries in OQGRAPH. #256

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

pprkut
Copy link
Contributor

@pprkut pprkut commented Nov 8, 2016

This was partially discussed on oqgraph-devel (thread starting at https://lists.launchpad.net/oqgraph-dev/msg00319.html) with @pastcompute, but not fully reviewed yet.

@pastcompute
Copy link
Contributor

Good job @pprkut , including updating the test results. Looks obvious now on seeing your patch, but this has been hiding in plain sight since before 2013 :-/ Sorry I couldn't help much, its been a long time since I used any of this
Your same patch should apply without problems in 10.1 I would expect, too

@svoj
Copy link

svoj commented Nov 11, 2016

Hi Heinz,

Thanks for your contribution. JIRA task just for the record: https://jira.mariadb.org/browse/MDEV-10980

This task was added to 10.2.5 backlog, which is planned to be handled between 2016-12-15 and 2016-12-22.

Similar to other open source projects, the MariaDB Foundation needs to have shared ownership of all code that is included in the MariaDB distribution. The easiest way to achieve this is by submitting your code under the BSD-new license.

The other alternative is to sign the code contribution agreement which can be found here: https://mariadb.com/kb/en/mariadb/mca/

Please indicate in a comment below that you are contributing your new code of the whole pull request, including one or several files that are either new files or modified ones, under the BSD-new license or that you have filled out the contribution agreement and sent it.

Thanks,
Sergey

@pprkut
Copy link
Contributor Author

pprkut commented Nov 11, 2016

Hi Sergey,

I hereby confirm that I contribute all changes and additions in this pull request under the BSD-new license.

@cvicentiu cvicentiu self-assigned this Feb 21, 2017
@svoj svoj added this to the 10.0 milestone Mar 1, 2017
@cvicentiu cvicentiu merged commit 4d33c74 into MariaDB:10.0 Oct 9, 2017
@cvicentiu
Copy link
Member

Hi @pprkut !

Sorry for such a delayed review. The patch works perfectly. Thank you very much for the contribution!

@pprkut
Copy link
Contributor Author

pprkut commented Oct 9, 2017

Awesome! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants