MDEV-31618: Server crashes in process_i_s_table_temporary_tables/get_all_tables #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an3l
commented
Jul 4, 2023
| SELECT table_schema, table_name FROM INFORMATION_SCHEMA.TABLES WHERE table_type='temporary sequence'; | ||
| table_schema table_name | ||
| test seq1 | ||
| mysqltest s2 |
There was a problem hiding this comment.
@vuvova not sure how this happened, when mysqltest is removed before?
tmp_mem_root maybe?
There was a problem hiding this comment.
sorry, I don't understand. what do you mean?
There was a problem hiding this comment.
The temporary sequences are shown because they where created in previous tests that did not clean up itself properly.
Fix by moving:
DROP TABLE mysqltest.s1;
DROP TABLE mysqltest.s2;
before the line
#MDEV-31618: Server crashes in
vuvova
requested changes
Jul 7, 2023
sql/sql_show.cc
Outdated
| @@ -5310,6 +5310,8 @@ int get_all_tables(THD *thd, TABLE_LIST *tables, COND *cond) | |||
| } | |||
|
|
|||
| TABLE *tmp_tbl= share_temp->all_tmp_tables.front(); | |||
| if(!tmp_tbl) | |||
| continue; | |||
There was a problem hiding this comment.
No, this is completely wrong. There cannot be a temporary table share without a single temporary table.
If this is the case here — it's a bug.
an3l
added a commit
to an3l/server
that referenced
this pull request
Jul 19, 2023
…all_tables - Mark temporary sequence as not needed to be reopen in case of renaming during alter prepare phase, since that operation will fail. - Without this patch, `find_temporary_table(0)` deletes the table from share - Closes PR MariaDB#2685 - Reviewer: <>
an3l
force-pushed
the
preview-11.2-preview-anel-MDEV-31618
branch
from
b47a95d
to
39f3418
Compare
an3l
added a commit
to an3l/server
that referenced
this pull request
Jul 19, 2023
…all_tables - Pre-open temporary table on sequence creation. - Without this patch, if rename alter is done on the temporary sequence, and after that `create replace`, since table is not preopened and alter rename marked the table as reopen, and such table is deleted in the `find_temporary_table()` leaving the share without the table, that causes `show tables` to fail - Closes PR MariaDB#2685 - Reviewer: <serg@mariadb.com>
an3l
force-pushed
the
preview-11.2-preview-anel-MDEV-31618
branch
from
39f3418
to
e334197
Compare
|
please, try to construct a test case that fails in earlier versions |
…all_tables - Pre-open temporary table on sequence creation. - Without this patch, if rename alter is done on the temporary sequence, and after that `create replace`, since table is not preopened and alter rename marked the table as reopen, and such table is deleted in the `find_temporary_table()` leaving the share without the table, that causes `show tables` to fail - Closes PR MariaDB#2685 - Reviewer: <serg@mariadb.com>
an3l
force-pushed
the
preview-11.2-preview-anel-MDEV-31618
branch
from
e334197
to
d4fe932
Compare
…isammrg::info - Fix MSAN uninitialized value error, obtained by calling handlerton's `info()`, and referencing uninitialized `errkey`. - Reviewer: serg@mariadb.com
an3l
force-pushed
the
preview-11.2-preview-anel-MDEV-31618
branch
from
c204487
to
c7edf8b
Compare
an3l
added a commit
that referenced
this pull request
Aug 2, 2023
…all_tables - Pre-open temporary table on sequence creation. - Without this patch, if rename alter is done on the temporary sequence, and after that `create replace`, since table is not preopened and alter rename marked the table as reopen, and such table is deleted in the `find_temporary_table()` leaving the share without the table, that causes `show tables` to fail - Closes PR #2685 - Reviewer: <serg@mariadb.com>
vuvova
pushed a commit
that referenced
this pull request
Aug 11, 2023
…all_tables - Pre-open temporary table on sequence creation. - Without this patch, if rename alter is done on the temporary sequence, and after that `create replace`, since table is not preopened and alter rename marked the table as reopen, and such table is deleted in the `find_temporary_table()` leaving the share without the table, that causes `show tables` to fail - Closes PR #2685 - Reviewer: <serg@mariadb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] The Jira issue number for this PR is: MDEV-31618
Basing the PR against the correct MariaDB version
PR quality check