Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-32130 Port MySQL test on protocol bug #106352 to MariaDB #2752

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-32130

Description

Port the test case from MySQL to MariaDB:

MySQL fix Bug#33813951, Change-Id: I2448e3f2f36925fe70d882ae5681a6234f0d5a98.

Function test_simple_temporal() from MySQL ported from C++ to pure C.

This includes one change:

  • DIE_UNLESS(field->type == MYSQL_TYPE_DATETIME);
  • DIE_UNLESS(field->type == MYSQL_TYPE_TIMESTAMP);

The bound param of SELECT ? is TIMESTAMP in this code. MySQL returns it back as DATETIME. MariaDB preserves TIMESTAMP.

How can this PR be tested?

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch.
  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.
  • *this is a test case backported to the earliest version supported/where it passes.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Port the test case from MySQL to MariaDB:

MySQL fix Bug#33813951, Change-Id: I2448e3f2f36925fe70d882ae5681a6234f0d5a98.

Function test_simple_temporal() from MySQL ported from C++ to pure C.

This includes one change:
-  DIE_UNLESS(field->type == MYSQL_TYPE_DATETIME);
+  DIE_UNLESS(field->type == MYSQL_TYPE_TIMESTAMP);

The bound param of SELECT ? is TIMESTAMP in this code.
MySQL returns it back as DATETIME. MariaDB preserves TIMESTAMP.

Code packaged for commit by Daniel Black.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@grooverdan
Copy link
Member Author

tests manually run as MDEV-16641 has them blocked.

main.mysql_client_test                   w1 [ pass ]  33134
main.mysql_client_test_nonblock          w2 [ pass ]  33134
main.mysql_client_test_comp              w3 [ pass ]  33134

Unblocked test: https://buildbot.mariadb.org/#/grid?branch=bb-10.4-MDEV-32130

@grooverdan grooverdan merged commit 5544ea2 into MariaDB:10.4 Sep 8, 2023
10 of 11 checks passed
@grooverdan grooverdan deleted the bb-10.4-MDEV-32130 branch March 5, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants