Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-11619: mtr --mem {no arguement of a directory} #320

Merged

Conversation

grooverdan
Copy link
Member

mtr --mem plugin was an issue because plugin was treated
as a directory where mtr treated as a tmp location rather
than a legitimate test name.

This removes functionality of where ./mtr --mem /tmp/dir could be
a directory.

Now MTR_MEM=/tmp/dir ./mtr is needed.

The case where MTR_MEM=/tmp/dir ./mtr --mem has the equalivant
effect.

Thanks Elena for helping and identifing edge cases.

I submit this under the MCA.

@elenst
Copy link
Member

elenst commented Feb 27, 2017

Thanks. There is also this fragment to remove:

+    # however if the opt_mem was given a value, use this first
+    unshift(@tmpfs_locations, $opt_mem) if $opt_mem ne '';

mtr --mem plugin was an issue because plugin was treated
as a directory where mtr treated as a tmp location rather
than a legitimate test name.

This removes functionality of where ./mtr --mem /tmp/dir could be
a directory.

Now MTR_MEM=/tmp/dir ./mtr is needed.

The case where MTR_MEM=/tmp/dir ./mtr --mem has the equalivant
effect.

Thanks Elena for helping and identifing edge cases.

Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
@grooverdan grooverdan force-pushed the 10.0-MDEV-11619-mtr---mem-no-arguement branch from 7a2cb40 to fb3712b Compare February 27, 2017 22:10
@elenst elenst merged commit b54566d into MariaDB:10.0 Feb 27, 2017
@grooverdan grooverdan deleted the 10.0-MDEV-11619-mtr---mem-no-arguement branch February 27, 2017 23:16
@svoj svoj added this to the 10.0 milestone Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants