MDEV-13909 Fix wsrep_sst_rsync fails on debian

[darkain]

Fix for the following error messages during SST:
/usr/local/mysql/bin/wsrep_sst_rsync: 258: /usr/local/mysql/bin/wsrep_sst_rsync: [[: not found
/usr/local/mysql/bin/wsrep_sst_rsync: 263: /usr/local/mysql/bin/wsrep_sst_rsync: [[: not found
/usr/local/mysql/bin/wsrep_sst_rsync: 268: /usr/local/mysql/bin/wsrep_sst_rsync: [[: not found

[svoj]

@darkain, thanks for your contribution! Could you confirm you contribute the whole pull request under MCA?

[darkain]

Yes, confirmed MCA contribution for this PR

[vuvova]

@darkain could you explain how this error could've happened?

wsrep_sst_rsync starts from #!/bin/bash -ue, and then it sources wsrep_sst_common. I'd expect wsrep_sst_common to be interpreted by bash, so [[ should've worked just fine.

If wsrep_sst_rsync gets somehow interpreted by /bin/sh we'll need to fix all other sst scripts not to use [[ either.

[darkain]

@vuvova Actually looking at it just now, wsrep_sst_rsync.sh starts with #!/bin/sh -ue - and my guess is because FreeBSD Jails have /bin/sh but not /bin/bash

https://github.com/MariaDB/server/blob/10.2/scripts/wsrep_sst_rsync.sh#L1

[vuvova]

Right. I was looking at 10.1 and 10.0, but in 10.2 it's /bin/sh, changed in f16ead51fbbf03ca51d (and, you're right, it was for FreeBSD).

Okay, then I'll change all other sst scripts too.

[eembsen]

Good morning @vuvova

I get this message with the MariaDB 10.3.2 Docker image:

mariadb02_1  | 2017-11-05 22:13:53 0 [Note] WSREP: (cecc4da4, 'tcp://0.0.0.0:4567') turning message relay requesting off
mariadb02_1  | WSREP_SST: [INFO] Joiner cleanup done. (20171105 22:13:54.059)
mariadb02_1  | 2017-11-05 22:13:54 0 [Note] WSREP: SST complete, seqno: 7113
mariadb01_1  | /usr//bin/wsrep_sst_rsync: 263: /usr//bin/wsrep_sst_rsync: [[: not found
mariadb01_1  | /usr//bin/wsrep_sst_rsync: 268: /usr//bin/wsrep_sst_rsync: [[: not found

Do I have to revert to 10.2.10? Or can I wait for version 10.3.3?

Cheers,
Erwin

[eembsen]

Hi @vuvova, just checked the 10.2.10 Docker hub image, to no avail :-(

[vuvova]

10.2.10 has the same issue. The fix (commit 98e09ee) is still only in 10.0-galera branch, waiting to be merged into 10.1 branch, then to 10.2 branch and then to 10.3 branch.

At the moment it's not in any release yet, I think.

[eembsen]

@vuvova Ok, thanks for the info. I hope that it soon will be available in the official MariaDB docker images. In the mean time I am going to patch the 10.3.2 image locally.