MDEV-13129: apport - sanitize wsrep_sst_auth from report #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hi @grooverdan, Thanks for your contribution. Corresponding JIRA task: https://jira.mariadb.org/browse/MDEV-13129 This task was added to 5.5 backlog. Thanks, |
|
Can you explain why we would need this for 5.5-galera ? Does it fix some critical issue ? If not, I could consider accepting this to 10.1. |
|
apport (ref: https://wiki.ubuntu.com/Apport) pushes info after a crash publicly and some people would rather not see their passwords there. Its a post process script who's failure just means the crash isn't pushed so its lower risk even on an a stable branch. |
|
thanks @janlindstrom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submit this under the MCA.