Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with undo and cloning #1217

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

rockfordlhotka
Copy link
Member

#1212 Fix issues with undo and cloning

@rockfordlhotka rockfordlhotka merged commit c6df8cc into MarimerLLC:master Jul 31, 2019
@rockfordlhotka rockfordlhotka deleted the 1212-undo-5 branch July 31, 2019 18:14
Copy link
Contributor

@b-higginbotham b-higginbotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read through all of the changes and everything looks pretty good. I think having IFieldData implement IMobileObject is probably the key that I was missing when I was working on #1080. I wasn't sure if there was any particular reason it didn't already implement that interface.

I pulled and built the code because I wanted to run through some testing, but unfortunately, I got hung up on some other issues with the data portal method changes so I didn't get to exercise this code as well as I'd like.

I'm not sure if the data portal method stuff is still considered to be a work in progress or if it's expected to be stable. If it's supposed to be stable, I can open another issue with my findings.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants